Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PowerShell to install in Sandbox #4332

Closed
wants to merge 1 commit into from

Conversation

glawrence
Copy link

This PR replaces #4264 which had a commit which I authored incorrectly

@prmerger-automator
Copy link
Contributor

@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit fe8a1c7:

✅ Validation status: passed

File Status Preview URL Details
hub/package-manager/winget/index.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Index File This PR contains a change to the index file.

@glawrence
Copy link
Author

Sorry @ShannonLeavitt @mattwojo @PDeets and @KevinLaMS this is new new PR which replaces #4264 but this one is in much better shape!

@mattwojo mattwojo assigned mattwojo and unassigned KevinLaMS Mar 10, 2023
@@ -36,11 +36,14 @@ Windows App Installer includes the production version of the winget tool. To try
To install the stable release of winget on Windows Sandbox, follow these steps from a Windows PowerShell command prompt:

```powershell
$ProgressPreference='Silent'
Invoke-WebRequest -Uri https://github.com/microsoft/winget-cli/releases/download/v1.3.2691/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle -OutFile .\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work with https://aka.ms/getwinget ? That way we don't necessarily have to update this with every release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work, and I am happy to change that, however given the dependencies changed between 1.3 and 1.4, if that happens again then this will still break. I don't know what is more likely, so happy to be guided

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely have to manage the dependencies in future changes. We're working on PowerShell DSC Resources that also contain the scripts to achieve this in a more supportable way in the future:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, shall I change the uri to https://aka.ms/getwinget then?

By the way, I personally prefer this PowerShell script way of installing winget into a running Sandbox, to the alternative of updating the sandbox disk image

@Jak-MS
Copy link
Contributor

Jak-MS commented Mar 10, 2023

@mattwojo

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 10, 2023
@mattwojo
Copy link
Contributor

mattwojo commented Apr 6, 2023

I think we finally got the right 'latest version' link in there with #4370 ....but please take a look @glawrence and let us know if you see any issues. Thanks for all your work digging in to help us get this script right!!

@mattwojo mattwojo closed this Apr 6, 2023
@glawrence
Copy link
Author

glawrence commented Apr 8, 2023

Thanks @mattwojo great to see you got this script updated via #4370. However I have tested it in Windows Sandbox on both Windows 10 and Windows 11 and in both places get the following error message:

Windows cannot install package Microsoft.DesktopAppInstaller_1.19.10173.0_x64__8wekyb3d8bbwe because this package depends on a framework that could not be found. Provide the framework
"Microsoft.UI.Xaml.2.7" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version
7.2109.13004.0, along with this package to install. The frameworks with name "Microsoft.UI.Xaml.2.7" currently installed are: {}
NOTE: For additional information, look for [ActivityId] 77cb7274-63fc-0000-b8ea-cb77fc63d901 in the Event Log or use the command line Get-AppPackageLog -ActivityID
77cb7274-63fc-0000-b8ea-cb77fc63d901

This is something that my script on this ticket specifically addressed, I am not sure how the new script deals with this.

learn-build-service-prod bot added a commit that referenced this pull request May 24, 2024
…c_temp

For protected branch, push strategy should use PR and merge to target branch method to work around git push error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants