-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PowerShell to install in Sandbox #4332
Conversation
@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit fe8a1c7: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
PRMerger Results
|
Sorry @ShannonLeavitt @mattwojo @PDeets and @KevinLaMS this is new new PR which replaces #4264 but this one is in much better shape! |
@@ -36,11 +36,14 @@ Windows App Installer includes the production version of the winget tool. To try | |||
To install the stable release of winget on Windows Sandbox, follow these steps from a Windows PowerShell command prompt: | |||
|
|||
```powershell | |||
$ProgressPreference='Silent' | |||
Invoke-WebRequest -Uri https://github.com/microsoft/winget-cli/releases/download/v1.3.2691/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle -OutFile .\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this work with https://aka.ms/getwinget ? That way we don't necessarily have to update this with every release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does work, and I am happy to change that, however given the dependencies changed between 1.3 and 1.4, if that happens again then this will still break. I don't know what is more likely, so happy to be guided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will likely have to manage the dependencies in future changes. We're working on PowerShell DSC Resources that also contain the scripts to achieve this in a more supportable way in the future:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, shall I change the uri to https://aka.ms/getwinget then?
By the way, I personally prefer this PowerShell script way of installing winget into a running Sandbox, to the alternative of updating the sandbox disk image
#label:"aq-pr-triaged" |
I think we finally got the right 'latest version' link in there with #4370 ....but please take a look @glawrence and let us know if you see any issues. Thanks for all your work digging in to help us get this script right!! |
Thanks @mattwojo great to see you got this script updated via #4370. However I have tested it in Windows Sandbox on both Windows 10 and Windows 11 and in both places get the following error message:
This is something that my script on this ticket specifically addressed, I am not sure how the new script deals with this. |
…c_temp For protected branch, push strategy should use PR and merge to target branch method to work around git push error
This PR replaces #4264 which had a commit which I authored incorrectly