Skip to content

Conversation

nedpyle
Copy link
Contributor

@nedpyle nedpyle commented Jan 21, 2023

PR Summary

Redesigned help to not be misleading about scopename: previous examples and help were often referring to failover clustering without being explicit, showing output that 99.9% of customers will never see because they are not running clusters. I am going to do this against get-smbshare, new-smbshare, set-smbshare, remove-smbshare as needed.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@nedpyle nedpyle changed the title Update Get-SmbShare.md for scopename and related example Update New-SmbShare.md for scopename and related example Jan 21, 2023
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 1cb3ca4:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review.

@michaeltlombardi michaeltlombardi merged commit cc0983d into MicrosoftDocs:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants