Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API review: Add Workers management APIs. #4556

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

monica-ch
Copy link
Contributor

This is the review for Workers Support in WebView2.

@monica-ch monica-ch added the API Proposal Review WebView2 API Proposal for review. label May 14, 2024
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
monica-ch and others added 2 commits June 5, 2024 11:09
Co-authored-by: David Risney <dave@deletethis.net>
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the comments I left. Please address those and let me know when you have a PR to main and I can schedule a review thanks.

specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
specs/Workers.md Outdated Show resolved Hide resolved
@monica-ch monica-ch merged commit 290dfaf into user/monicach/Workers Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Proposal Review WebView2 API Proposal for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants