Remove Sphinx for good

MiczFlor · Nov 11, 2023 · 3b23e7c · 3b23e7c
1 parent a707a24
commit 3b23e7c
Show file tree

Hide file tree

Showing 71 changed files with 11 additions and 3,739 deletions.
diff --git a/.flake8 b/.flake8
@@ -19,8 +19,6 @@ filename = *.py,*.py.*
 extend-exclude =
     # Ignore all scratch development directories
     scratch*,
-    # The conf file is mostly autogenerated, ignore it
-    docs/sphinx/conf.py,
     # Ignore dirs and files that have not been ported yet
     */jukebox/NvManager.py
     # ignore GitHub Codespaces

diff --git a/.githooks/pre-commit b/.githooks/pre-commit
@@ -26,18 +26,7 @@ if [[ -n $PY_FILES ]]; then
   echo "Flake8 return code: $flake8_code"
 fi
 
-DOC_FILES="$(git diff --diff-filter=d --staged --name-only -- docs/sphinx/*)"
-sphinx_code=0
-if [[ -n $DOC_FILES || -n $PY_FILES ]]; then
-  echo -e "\n**************************************************************"
-  echo -e "Files for documentation modified. Testing re-build of docs ... \n"
-  echo -e "**************************************************************\n"
-  ./run_sphinx.sh -c
-  sphinx_code=$?
-  echo "Sphinx return code: $sphinx_code"
-fi
-
-code=$(( flake8_code + sphinx_code ))
+code=$(( flake8_code ))
 
 if [[ code -gt 0 ]]; then
   echo -e "\n**************************************************************"

diff --git a/.github/workflows/pythonpackage_future3.yml b/.github/workflows/pythonpackage_future3.yml
@@ -7,14 +7,12 @@ on:
     paths:
         - '**.py'
         - '**.py.*'
-        - 'docs/sphinx/**'
   pull_request:
     branches:
         - 'future3/**'
     paths:
         - '**.py'
         - '**.py.*'
-        - 'docs/sphinx/**'
 
 jobs:
   build:
@@ -40,9 +38,6 @@ jobs:
         pip3 install spidev
         pip3 install -r requirements.txt
         # For operation of the Jukebox, ZMQ must be compiled from sources due to Websocket support
-        # When just building the docs, the regular ZMQ package is sufficient
-        pip3 install -r docs/sphinx/requirements_pyzmq.txt
-        pip3 install -r docs/sphinx/requirements.txt
         # Also install all optional dependencies
         pip3 install -r src/jukebox/components/rfid/hardware/fake_reader_gui/requirements.txt
         pip3 install -r src/jukebox/components/rfid/hardware/pn532_i2c_py532/requirements.txt
@@ -53,9 +48,3 @@ jobs:
         pip3 install flake8
         # Stop the build if linting fails
         ./run_flake8.sh
-    - name: Build the docs
-      working-directory: ./docs/sphinx
-      run: |
-        # Stop the build if documentation cannot be built
-        # Treat all warnings as errors
-        sphinx-build -W --keep-going -T -a -E -b html . _build
diff --git a/.gitignore b/.gitignore
@@ -7,9 +7,6 @@
 /shared/*.*
 /shared/*
 
-# Documentation builder
-/docs/sphinx/_build/
-
 # Application
 /src/cli_client/pbc
 

diff --git a/.readthedocs.yaml b/.readthedocs.yaml
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -26,7 +26,6 @@ The Jukebox core app is written entirely in Python. Therefore, we follow the [Py
 
 * **Documentation**
   * You are expected to write some Documentation. It's easy. **Very** easy actually with [Python Docstrings](https://www.geeksforgeeks.org/python-docstrings/)
-  * If you dare, you may add the python documentation reference to the Sphinx documentation build. But we are also ok with doing that for you
 
 # Structure of files and folders
 
@@ -38,8 +37,6 @@ Inside the root folder or the repo, these folders are important:
   * contains the Python packages that are loaded using the plugin interface
 * `src/webapp`
   * contains the Web Interface
-* `src/docs/sphinx`  
-  * contains the documentation sources and build flow using Sphinx
 
 All folders on all hierarchy levels starting with `scratch*` are ignored by git and flake8. These are intended
 as local, temporary scratch areas.
@@ -132,18 +129,6 @@ cd /home/pi/RPi-Jukebox-RFID
 If you are convinced some issue should not apply to your case or would require extensive re-coding, that could be OK.
 Let us know in the pull request - we will look at it.
 
-### Documentation
-
-When adding or improving documentation, build the documentation and look at it locally.
-If you are contributing to existing Python modules, be aware that these are already included in the documentation flow.
-Also run through this step in this case! Fix all warnings!
-
-~~~bash
-$ cd /home/pi/RPi-Jukebox-RFID/
-$ ./run_sphinx.sh
-# open and check the result: 'file:///path/to/RPi-Jukebox-RFID/docs/sphinx/_build/html/index.html'
-~~~
-
 ### Tests
 
 Tests are very few at the moment, but it cannot hurt to run them. If you have tests for your new modules, please add

diff --git a/README.md b/README.md
@@ -11,24 +11,7 @@ project check out the [documentation of Version 2](<https://github.com/MiczFlor/
 
 ## Where are the Help pages?
 
-### Online
-
-Read the documentation at [Readthedocs.io](https://rpi-jukebox-rfid.readthedocs.io/en/latest/)
-
-### Local
-
-Alternatively, build the help locally:
-
-~~~bash
-cd docs/sphinx
-make
-~~~
-
-Then navigate your browser to
-
-~~~bash
-file:///path/to/RPi-Jukebox-RFID/docs/sphinx/_build/html/docs/index.html
-~~~
+The documentation can be found [here](documentation)
 
 ## Installation?
 

diff --git a/docker/build-documentation.Dockerfile b/docker/build-documentation.Dockerfile
diff --git a/docker/docker-compose.linux.yml b/docker/docker-compose.linux.yml
@@ -27,16 +27,3 @@ services:
       - ../shared:/home/pi/RPi-Jukebox-RFID/shared
       - ./config/docker.pulse.mpd.conf:/home/pi/.config/mpd/mpd.conf
       - $XDG_RUNTIME_DIR/pulse/native:/tmp/pulse-sock
-
-  documentation:
-    build:
-      args:
-        - UID=${UID:-1000}
-        - USER=pi
-        - HOME=/home/pi
-    environment:
-      - PULSE_SERVER=unix:/tmp/pulse-sock
-    volumes:
-      - ../shared:/home/pi/RPi-Jukebox-RFID/shared
-      - ./config/docker.pulse.mpd.conf:/home/pi/.config/mpd/mpd.conf
-      - $XDG_RUNTIME_DIR/pulse/native:/tmp/pulse-sock
diff --git a/docker/docker-compose.mac.yml b/docker/docker-compose.mac.yml
@@ -10,8 +10,3 @@ services:
     volumes:
       - ~/.config/pulse:/root/.config/pulse
       - /usr/local/Cellar/pulseaudio/14.2/etc/pulse:/etc/pulse
-
-  documentation:
-    volumes:
-      - ~/.config/pulse:/root/.config/pulse
-      - /usr/local/Cellar/pulseaudio/14.2/etc/pulse:/etc/pulse
diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml
@@ -44,23 +44,6 @@ services:
       - ./config/docker.pulse.mpd.conf:/root/.config/mpd/mpd.conf
     command: python3 run_jukebox.py
 
-  documentation:
-    profiles: ["documentation"]
-    build:
-      args:
-        - UID=0
-        - USER=root
-        - HOME=/root
-      context: ../
-      dockerfile: ./docker/build-documentation.Dockerfile
-    container_name: documentation
-    image: phoniebox/build-documentation
-    tty: true
-    volumes:
-      - ../shared:/root/RPi-Jukebox-RFID/shared
-      - ./config/docker.pulse.mpd.conf:/root/.config/mpd/mpd.conf
-    command: python3 ../../run_sphinx.py
-
   webapp:
     build:
       context: ../

diff --git a/docker/webapp.Dockerfile b/docker/webapp.Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-alpine
+FROM node:18-bullseye-slim
 
 USER node
 RUN mkdir -p /home/node/webapp

diff --git a/documentation/content/developers/coreapps.md b/documentation/content/developers/coreapps.md
@@ -54,23 +54,3 @@ The list of available commands is fetched from the running Jukebox service.
 ### run_publicity_sniffer.py
 
 A command line tool that monitors all messages being sent out from the Jukebox via the publishing interface. Received messages are printed in the console. Mainly used for debugging.
-
-### run_sphinx.sh (Legacy: TO BE REMOVED)
-
-This command rebuilds the documentation using a Sphinx flow, located in
-the main directory.
-
-The documentation is built partially from auto-generated RST-files. Thee
-files contain the
-`userguide/rpc_command_reference:RPC Command Reference`{.interpreted-text
-role="ref"} and
-`userguide/rpc_command_alias_reference:RPC Command Alias Reference`{.interpreted-text
-role="ref"}.
-
-``` bash
-run_jukebox.py -a
-```
-
-The above command regenerate these RST files. This only needs to be done
-when the RPC call references need to be updated within the documentation
-flow.
diff --git a/documentation/content/developers/rfid/template_reader.md b/documentation/content/developers/rfid/template_reader.md
@@ -26,9 +26,7 @@ components/rfid/hardware/awesome_reader/
   +- README.rst         <-- The Readme
 ```
 
-The module documentation must go into a separate file so we can import
-it into the Sphinx document generation flow without loading the Python
-module.
+The module documentation must go into a separate file, called README.ME.
 
 ## Conventions
 

diff --git a/documentation/sphinx/_templates/footer.html b/documentation/sphinx/_templates/footer.html
diff --git a/documentation/sphinx/api/api.rst b/documentation/sphinx/api/api.rst
diff --git a/documentation/sphinx/api/callingback.rst b/documentation/sphinx/api/callingback.rst
diff --git a/documentation/sphinx/api/cfghandler.rst b/documentation/sphinx/api/cfghandler.rst
diff --git a/documentation/sphinx/api/controls.rst b/documentation/sphinx/api/controls.rst
diff --git a/documentation/sphinx/api/gpioz/connector.rst b/documentation/sphinx/api/gpioz/connector.rst
diff --git a/documentation/sphinx/api/gpioz/converter.rst b/documentation/sphinx/api/gpioz/converter.rst