Disable spotify installation in install scripts #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2022
s-martin
approved these changes
Jun 3, 2022
| # Requires Spotify username, password, client_id and client_secret | ||
| # to get connection to Spotify. | ||
| # IMPORTANT: Spotify disabled access to libspotify. | ||
| # Therefore no spotify integration possible. |
There was a problem hiding this comment.
Suggestion: “…no spotify integration possible at the moment.”
| # Requires Spotify username, password, client_id and client_secret | ||
| # to get connection to Spotify. | ||
| # IMPORTANT: Spotify disabled access to libspotify. | ||
| # Therefore no spotify integration possible. |
| # Requires spotify username, password, client_id and client_secret | ||
| # to get connection to Spotify. | ||
| # IMPORTANT: Spotify disabled access to libspotify. | ||
| # Therefore no spotify integration possible. |
| @@ -296,70 +296,20 @@ clear | |||
|
|
|||
There was a problem hiding this comment.
We could delete the stretch file. AS far as I remember the installation on stretch doesn’t work anymore.
| @@ -792,7 +750,6 @@ install_main() { | |||
|
|
|||
There was a problem hiding this comment.
mopidy is also not necessary
|
As #2064 is around the corner, I think we could close this PR, @Groovylein ? |
Merged
|
Obsolete with implementation of #2315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I focused on buster installation.
The stretch installation changes were only a quick fix.
Not tested yet.
Have no time for that right now. Can someone test it?