Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docker images on bookworm #2080

Closed
wants to merge 6 commits into from
Closed

Run docker images on bookworm #2080

wants to merge 6 commits into from

Conversation

s-martin
Copy link
Collaborator

@s-martin s-martin commented Oct 16, 2023 •
edited
Loading

Changes so far to make the install script running on Bookworm

  • Use venv as Bookworm implemented PEP668
  • Explicitly install netcat-traditional package
  • ...

@s-martin s-martin marked this pull request as draft October 16, 2023 20:58
@AlvinSchiller
Copy link
Collaborator

Hey, i've had the same idea the other day :)
Just that we don't overlap. Im currently trying to harmonise the test and docker files to have not that much duplication and let all tests run in parallel to minimize wait time.
Haven't created a PR yet, as it is a lot trial and error, but should take to long any more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6565900642

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.82%
Totals Coverage Status
Change from base Build 6475115007: 0.0%
Covered Lines: 633
Relevant Lines: 824
💛 - Coveralls

@s-martin
Copy link
Collaborator Author

Maybe sudo is missing for venv....

@s-martin s-martin mentioned this pull request Oct 22, 2023
Merged
3 tasks
@s-martin
Copy link
Collaborator Author

Better implementation in #2084

@s-martin s-martin closed this Oct 22, 2023
@s-martin s-martin deleted the try_bookworm branch January 4, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-martin @AlvinSchiller @coveralls