-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace RPi.GPIO with rpi-lgpio for V3 future3 #2470
base: future3/develop
Are you sure you want to change the base?
Conversation
Anybody using a RC522 reader is welcome to test the change (also #2469 if you use V2) as I don't have a RC522 reader. |
Is the API interchangeable? It seems easy, but should be tested with some default components |
@@ -30,6 +30,8 @@ _jukebox_core_install_python_requirements() { | |||
source "$VIRTUAL_ENV/bin/activate" | |||
|
|||
pip install --upgrade pip | |||
# Remove RPi.GPIO, if still installed - see https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/2313 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea, but I don't think we need it. Our installation does not qualify for reinstallation anyways. It should not be installed by default.
Just thought about checking the installed package (and making sure RPi.GPIO is not installed) at least in the CI, but I realized that we don’t have these CI checks in future3 yet. |
I think for future3 to fix the rc522 issues https://github.com/hoffie/pi-rc522-gpiozero would be a good solution as we use gpiozero anyway in future3. |
Added task to build rpi-lgpio manually on Bullseye - some users already tried to install on Bullseye (#2481 (comment)) |
Following the discussion in #2313 replacing RPi.GPIO with rpi-lgpio
RPi-Jukebox-RFID/src/jukebox/components/rfid/configure/__init__.py
Lines 29 to 37 in 0ee5bc3
@hoffie @varac