Simple powered up led #387

topas-rec · 2018-12-15T10:15:22Z

In my opinion a good addition to find out if usb power connection can be safely disconnected between Raspberry Pi and the Power bank using an external switch.
Led is turned on, when Pi is running, when pushing power button is blinks two times to indicate shutdown initiated. Then is stays on until Pi loses power. Now one can disconnect power safely.

Led uses free GPIO 3.
Can be ignored if led is not used.

Renamed GPIO buttons file because it now also controls led.

I made video of the functionality, but need to upload it somewhere.

I think other stores are better than supporting amazon.

All needed items entered and added a status and if possible a link to exact part

Adopted shopping list in terms of - buttons - led including resistor - power pack - RJ45 adapter - USB charging outlet - Jumper cables for buttons - Visaton speaker and amp

Status led shows if phoniebox ist in service to an LED connected to GPIO 2

Install script no longer deletes old gpio-button service but already more general gpio service. Small code improvements to LED script.

GPIO service still called old gpio-buttons script

Now gpio gets removed instead of gpio-buttons

- Returning USB speakers - Received components

Led blinks for half a second off and half a second on after pressing and during shutdown.

Led blinks two times and stays on until shutdown completes. This fixes that the led randomly goes off caused by continued blinking and shutdown.

Conflicts: misc/sampleconfigs/gpio-buttons.py.sample Merged into gpio.py.sample

Imported comment from upstream. Commented led behavior when shutting down.

Some changes from fork master were in the led only change branch. Fixed it. Now just the led change should be in this branch.

Conflicts: README.md scripts/installscripts/stretch-install-default.sh

topas-rec · 2018-12-15T10:56:11Z

I think this will not destroy the "no soldering" solution, because one can easily ignore the led like the gpio buttons.

topas-rec · 2018-12-15T10:57:43Z

I have not checked the update conditions in detail. I fyou want to merge we should concider the renamed file (gio-buttons.py to gpio.py) in the install script(s).

topas-rec · 2018-12-15T11:09:52Z

This is a small video of the functionality.

VID_20181215_105739.m4v.zip

topas-rec · 2018-12-15T11:13:28Z

scripts/installscripts/stretch-install-default.sh

@@ -482,30 +482,30 @@ echo "### Deleting older versions of service daemons. This might throw errors, i
 sudo systemctl disable idle-watchdog
 sudo systemctl disable rfid-reader
 sudo systemctl disable startup-sound
-sudo systemctl disable gpio-buttons


This should stay for a while I guess right?

topas-rec · 2018-12-15T11:13:32Z

scripts/installscripts/stretch-install-default.sh

 sudo rm /etc/systemd/system/rfid-reader.service 
 sudo rm /etc/systemd/system/startup-sound.service
-sudo rm /etc/systemd/system/gpio-buttons.service


This should stay for a while I guess right?

martinclausen2 · 2018-12-16T14:56:15Z

Hi @topas-rec, GPIO 3 is not free, it is currently GPIO to power up and down and can not be chnaged to other pins (wake-up is special pin requirement).
Please find a suitable pin by considering the new pinout

MiczFlor · 2018-12-17T18:05:17Z

Hi @topas-rec @martinclausen2
thanks for the contribution and thanks for pointing out the conflict. Is there a way to modify the code to follow the GPIO "best practice" ideas?

martinclausen2 · 2018-12-19T10:49:43Z

Hi @topas-rec , a suggestion GPIO 7 is free.

topas-rec · 2018-12-23T09:07:13Z

Can you confirm that and then tell me if this gpio is free?
This gpio.py script works on my phoniebox together with the gpio buttons exactly implemented according to the wiki suggestion: https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Using-GPIO-hardware-buttons

That's why I didn't believe there is a conflict between the led and the shutdown button, because I use them together.

topas-rec · 2018-12-23T09:10:42Z

OK found out that the gpio 2 is a conflict for the i2c protocol for the hifiberry. Correct?
So changing to gpio 7 is still necessary right?

MiczFlor · 2018-12-25T12:30:58Z

Hi @topas-rec
this is still pending for two reasons. The first one I can not solve: I have not GPIO installed at the moment and can not test nor verify which pin should be used.
Secondly, you are right, the name of the script should change, because it's not only about buttons anymore. However, I do not want to deal with the disappointed parents after a git pull - which is why I would like to leave the filename as it is now.
All the best, micz

topas-rec · 2020-01-28T17:42:35Z

If I remember correctly renaming of next was already done in develop branch.

Jepp. Thats why I changed to the develop branch. Getting this fix into this PR can be done in one shot instead of doing it later when merging develop in master.

topas-rec · 2020-01-28T17:43:47Z

This PR was targeted to master. In master the next changes are not merged.

simple_powered_up_led Conflicts: misc/sampleconfigs/gpio-buttons.py.sample misc/sampleconfigs/phoniebox-rfid-reader.service.stretch-default.sample scripts/RegisterDevice.py scripts/installscripts/buster-install-default.sh All files taken over except of gpio-buttons.py.sample

topas-rec · 2020-01-28T19:27:49Z

LED changed to GPIO 12
Renaming next variables done

I'll test this soon. If someone can test it that would help.
I saw the rfid switch off function and adopted it to work with RPi.GPIO. @tobias-snapit might want to test that. (It is commented out - as it was before)

I think this can be merged already since the GPIO and LED code was already tested before.

topas-rec · 2020-01-29T20:41:27Z

Tested with current buster install script (develop branch) and with GPIO 12.

Works right after install and works as expected.

Please merge.

veloxidSchweiz · 2020-01-31T18:59:28Z

Hi @topas-rec ,
I am wondering why you removed the gpiozero module?
Isn't it possible to implement it with gpiozero?
actually another nice way to do this would be to use a
dtoverlay:
dtoverlay=gpio-poweroff,gpiopin=13
would power on gpiopin 13 (if i remember correctly BCM) as soon as power is down and the rpi can be put off.
It can als be used in inverted mode by using ,active_low="y"....

martinclausen2 · 2020-01-31T19:58:53Z

Hi @veloxidSchweiz a year oago I removed carefully gpio.zero for performance reasons:
#387 (comment)
As you noticed here #763 it is advisable to use less different libs for the same task. So we agreed on dropping gpiozero at the time to my understanding. If you use a RPi 4 you will likely not notice, but for a Pi Zero it is a different story.

veloxidSchweiz · 2020-01-31T21:43:42Z

Hi @martinclausen2 ,
Thanks for the explanation, I wasn't aware of that.
I am usually not using the Pi Zero nor a RPi4 but RPI 3 therefore i probably haven't recognized it.
At the end i think it is the best at least to agree on one interface.
After reading the discussions here, I am asking me if the idea of the common base class goes somehow in the same direction I am suggesting in #763 ...

topas-rec · 2020-02-06T19:53:16Z

Can someone of the maintainers please explain to me why this is not going to be merged or rejected? I see a lot of discussion going on around config files and reorganizing the project. I think that is all great. Does it has to do with this PR? Is that the reason that this PR is not merged? Are there other reasons?

This PR is open for a year now and I am afraid someday I find a whole different project and my changes do not fit anymore and I can rewrite this (small) change. I don't have so much time so I am not sure to be able to keep up with the projects speed.

…p_led

MiczFlor · 2020-02-07T12:19:21Z

Hi @topas-rec
you are absolutely right. Did you rebase your work to the latest version of the script? I will merge it immediately. I am not super up to date with the status of your contribution. Apologies!
All the best, micz

…p_led

topas-rec · 2020-02-07T15:00:36Z

I did not rebase but I merged your development branch into this branch just now.
So yes, in my branch are the latest changes of the script.

topas-rec · 2020-02-07T17:41:39Z

@MiczFlor everything is up to date - please merge.

narf0815 · 2020-04-15T09:14:34Z

is there a way to simply implement this in stable?
as mentioned here i have some trouble with developer...

(am i supposed to post here?)

topas-rec · 2020-04-15T11:26:33Z

It has to be merged by a maintainer.

You can copy the file gpio-buttons.py from develop to your box manually until it is merged.

narf0815 · 2020-04-15T13:24:49Z

i tried my working develop gpio-buttons.py file on my stable version but LED does still not work on stable.

topas-rec · 2020-04-15T13:46:48Z

Led connected as described here?
https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Using-GPIO-hardware-status-led

narf0815 · 2020-04-15T14:00:42Z

yes. and it's working on my "develop-sdcard"

topas-rec · 2020-04-15T15:29:47Z

So just not working when copying the develop file gpio-buttons.py into the stable (master) branch?

I don't have an idea why. For me this file was always like an atomic thing. Works when present.

Can you put a debug printf in that file to see what that code does and why the led doesn't light up?

You can see these printf by looking in the /var/log/syslog file.
You can use the tail command for automatically refreshing through SSH session.

narf0815 · 2020-04-15T15:37:46Z

So just not working when copying the file gpio-buttons.py into the stable (master) branch?

exactly

Can you put a debug printf in that file to see what that code does and why the led doesn't light up?

huh. if you tell me where to put what i shure could.

topas-rec · 2020-04-15T19:53:11Z

General printing of messages in python:
https://www.w3schools.com/python/ref_func_print.asp

topas-rec · 2020-04-15T20:02:01Z

@MiczFlor let us know if this should better be discussed in an issue rather than in a merged PR.

narf0815 · 2020-04-15T20:34:05Z

i'm afraid this is (far) above my "potential".
hope this comes to stable soon so i/my kids can have volume rotary encoder and LED.

thanks for your effort however!

edit: oh my, this is truly way above me... with just changing the gpio-buttons.py none of the buttons work anymore as before. (yes - with correct gpios)

s-martin · 2020-04-16T09:00:33Z

We're working on releasing 2.0 "soon" although I can't give you a date. Please see #890 for coordination of the release.

topas-rec added 19 commits November 29, 2018 21:52

Changed amazon links to stores other than amazon

a53a4a9

I think other stores are better than supporting amazon.

Set up

420e414

All needed items entered and added a status and if possible a link to exact part

Adopted shopping list

2d3c2d1

Adopted shopping list in terms of - buttons - led including resistor - power pack - RJ45 adapter - USB charging outlet - Jumper cables for buttons - Visaton speaker and amp

Added status led

5c8fc12

Status led shows if phoniebox ist in service to an LED connected to GPIO 2

Updated install script to general gpio service removal

5926ee3

Install script no longer deletes old gpio-button service but already more general gpio service. Small code improvements to LED script.

Fixed: GPIO service calling wrong script

3ebaccc

GPIO service still called old gpio-buttons script

Fixed old service removal

09951e1

Now gpio gets removed instead of gpio-buttons

Updated shopping list

2025b9c

- Returning USB speakers - Received components

Merge branch 'shopping_list_personlisation'

f11a22b

Led blinks during shutdown

29e46e2

Led blinks for half a second off and half a second on after pressing and during shutdown.

Merge branch 'simple_powered_up_led'

c853cd8

Merge remote-tracking branch 'upstream/master'

d4ec46b

Led blinks and stays on after shutdown button pushed

f69c6f0

Led blinks two times and stays on until shutdown completes. This fixes that the led randomly goes off caused by continued blinking and shutdown.

Merge branch 'simple_powered_up_led'

0e6fc41

Merge remote-tracking branch 'upstream/master'

4bd0880

Conflicts: misc/sampleconfigs/gpio-buttons.py.sample Merged into gpio.py.sample

Imported changes from upstream and made comments

b751c77

Imported comment from upstream. Commented led behavior when shutting down.

Merge branch 'simple_powered_up_led'

eedaeb7

Aligned with upstream master

16d2997

Some changes from fork master were in the led only change branch. Fixed it. Now just the led change should be in this branch.

Merge branch 'master' into simple_powered_up_led

9770955

Conflicts: README.md scripts/installscripts/stretch-install-default.sh

topas-rec commented Dec 15, 2018

View reviewed changes

s-martin mentioned this pull request Jan 31, 2020

RotaryEncoder based on gpiozero #763

Merged

Merge remote-tracking branch 'upstream/develop' into simple_powered_u…

0e5ab5e

…p_led

Merge remote-tracking branch 'upstream/develop' into simple_powered_u…

b0619ab

…p_led

s-martin approved these changes Feb 7, 2020

View reviewed changes

MiczFlor merged commit 7a67b58 into MiczFlor:develop Feb 8, 2020

topas-rec mentioned this pull request Apr 16, 2020

Release 2.0 #890

Closed

8 tasks

topas-rec deleted the simple_powered_up_led branch March 18, 2023 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simple powered up led #387

Simple powered up led #387

topas-rec commented Dec 15, 2018

topas-rec commented Dec 15, 2018

topas-rec commented Dec 15, 2018

topas-rec commented Dec 15, 2018

topas-rec Dec 15, 2018

topas-rec Dec 15, 2018

martinclausen2 commented Dec 16, 2018

MiczFlor commented Dec 17, 2018

martinclausen2 commented Dec 19, 2018

topas-rec commented Dec 23, 2018 •

edited

Loading

topas-rec commented Dec 23, 2018

MiczFlor commented Dec 25, 2018

topas-rec commented Jan 28, 2020 •

edited

Loading

topas-rec commented Jan 28, 2020

topas-rec commented Jan 28, 2020

topas-rec commented Jan 29, 2020

veloxidSchweiz commented Jan 31, 2020

martinclausen2 commented Jan 31, 2020

veloxidSchweiz commented Jan 31, 2020

topas-rec commented Feb 6, 2020

MiczFlor commented Feb 7, 2020

topas-rec commented Feb 7, 2020

topas-rec commented Feb 7, 2020

narf0815 commented Apr 15, 2020

topas-rec commented Apr 15, 2020

narf0815 commented Apr 15, 2020 •

edited

Loading

topas-rec commented Apr 15, 2020

narf0815 commented Apr 15, 2020

topas-rec commented Apr 15, 2020 •

edited

Loading

narf0815 commented Apr 15, 2020

topas-rec commented Apr 15, 2020

topas-rec commented Apr 15, 2020

narf0815 commented Apr 15, 2020 •

edited

Loading

s-martin commented Apr 16, 2020

Simple powered up led #387

Simple powered up led #387

Conversation

topas-rec commented Dec 15, 2018

topas-rec commented Dec 15, 2018

topas-rec commented Dec 15, 2018

topas-rec commented Dec 15, 2018

topas-rec Dec 15, 2018

Choose a reason for hiding this comment

topas-rec Dec 15, 2018

Choose a reason for hiding this comment

martinclausen2 commented Dec 16, 2018

MiczFlor commented Dec 17, 2018

martinclausen2 commented Dec 19, 2018

topas-rec commented Dec 23, 2018 • edited Loading

topas-rec commented Dec 23, 2018

MiczFlor commented Dec 25, 2018

topas-rec commented Jan 28, 2020 • edited Loading

topas-rec commented Jan 28, 2020

topas-rec commented Jan 28, 2020

topas-rec commented Jan 29, 2020

veloxidSchweiz commented Jan 31, 2020

martinclausen2 commented Jan 31, 2020

veloxidSchweiz commented Jan 31, 2020

topas-rec commented Feb 6, 2020

MiczFlor commented Feb 7, 2020

topas-rec commented Feb 7, 2020

topas-rec commented Feb 7, 2020

narf0815 commented Apr 15, 2020

topas-rec commented Apr 15, 2020

narf0815 commented Apr 15, 2020 • edited Loading

topas-rec commented Apr 15, 2020

narf0815 commented Apr 15, 2020

topas-rec commented Apr 15, 2020 • edited Loading

narf0815 commented Apr 15, 2020

topas-rec commented Apr 15, 2020

topas-rec commented Apr 15, 2020

narf0815 commented Apr 15, 2020 • edited Loading

s-martin commented Apr 16, 2020

topas-rec commented Dec 23, 2018 •

edited

Loading

topas-rec commented Jan 28, 2020 •

edited

Loading

narf0815 commented Apr 15, 2020 •

edited

Loading

topas-rec commented Apr 15, 2020 •

edited

Loading

narf0815 commented Apr 15, 2020 •

edited

Loading