Feature/configureable gpio buttons #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-martin
approved these changes
Apr 16, 2020
|
Would this implementation replace the existing gpio-buttons.py file completely? If yes, then we should think about how we roll this out. One idea could be to leave like it is for 2.0 and maybe provide a howto how interested users could use it and migrate their installation. For 3.0 we could then make it the default implementation, but then we should provide a (automatic) migration of existing settings. |
This is only a check for this component. but probably a good idea to somehow define what is required for automatic testing of components... |
|
damn i didn't wanted to create confligting files... made something wrong when rebasing /merging develop (I am not used to the github fork workflow...) |
veloxidSchweiz
force-pushed
the
feature/configureableGPIOButtons
branch
from
79589e2 to
63d39f6
Compare
s-martin
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I had a little bit of time to include two simple LEDs in the new gpio_control class.
One which lights up as soon as the gpio_control is started(device=LED), the other one only when a connection to MPD/mopidy can be established (MPDStatusLED)
I am NOT yet checking on a regulary basis if the connection is still there but that would be the next step. Also included an example config but the pins should probably be updated to correspond to the right pins....
( I also did a minor refactoring and moved the VolumeControl class)