Add environment variable for supplier contracts bucket (#803) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriHoch
suggested changes
Apr 17, 2018
| @@ -59,4 +59,7 @@ data: | |||
| {{ if .Values.volunteersBaseUrl }} | |||
| VOLUNTEERS_BASE_URL: {{ .Values.volunteersBaseUrl | quote }} | |||
| {{ end }} | |||
|
|
|||
| # SUPPLIER CONTRACT FILES | |||
| SPARK_SUPPLIER_CONTRACTS_BUCKET: {{ .Values.suppliers.bucket | quote }} | |||
There was a problem hiding this comment.
each chart has access only to values under it's name (and the global property)
so, in your case it should be under
{{ .Values.suppliersBucket | quote }}
also, you should check if value exists before adding it - see the example of volunteersBaseUrl above your code
environments/staging/values.yaml
Outdated
| @@ -121,3 +121,6 @@ dreams: | |||
| camps-index: | |||
| enabled: true | |||
| sparkAppSecretName: sparkdb-app | |||
|
|
|||
| suppliers: | |||
| bucket: midburn-spark-supplier-files | |||
There was a problem hiding this comment.
this value will only be visible to suppliers chart, it won't be accessible for spark chart
- Check for existing config value before adding it - Flatten suppliers hierarchy
OriHoch
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created the buckets midburn-spark-supplier-files and midburn-spark-supplier-files-prod
The are accessible by the same aws user, spark, that is currently configured on production.