Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full diff #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Full diff #212

wants to merge 2 commits into from

Conversation

nschaeff
Copy link

@nschaeff nschaeff commented Jun 1, 2023

Provides full diff (all files) between two commits for git and mercurial.
Usage:

diffuse -c commit1..commit2   # displays the diff between commi1 and commit2

Provides a partial answer to issue #190 for git and mercurial only.

@MightyCreak
Copy link
Owner

Interesting change! Thanks for the contribution!

I'm still locked outside of my personal computer, so everything's a bit slow(er) right now on Diffuse.

I'll need to check if this change is not injecting unwanted behaviors before approving it, and also update the docs if this new feature is accepted.

@nschaeff
Copy link
Author

Any chance to have this merge in the near future? What is missing?

@MightyCreak
Copy link
Owner

Any chance to have this merge in the near future? What is missing?

Sorry, I simply didn't get the time to address this.

I looked at the changes though and it seems to add the possibility to use a new revX..revY format. This syntax works with git and hg, but what's gonna happen if you use it on other VCS? Diffuse allows to get an abstraction from these various syntaxes, so -c is the same for all the VCS.

This change changes that, though it keeps the original syntax and simply adds a new format, just for git and hg.

@joyously
Copy link

what's gonna happen if you use it on other VCS?

I was trying to add what is needed for the other VCSs, but ran into trouble with the development environment. I opened an issue about it, but have gotten silence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants