Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean support addition #81

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

turbobit
Copy link
Contributor

This pull request aims to add Korean support in lunr-languages list.

What i did

  • Add Korean support
  • except Japanese, all the lunr.<language>.js files are built from build/lunr.template
    • If lunr.template does not fit your needs (for example for non-latin characters), just copy any lunr.<language>.js file and start modifying
  • you must also test your new language
    • go to test/testdata and create a new file, then link it to VersionsAndLanguagesTest.js
    • make sure you cover many testcases (wildcard, stemming)
    • image
    • your tests will automatically be run on all the Lunr versions
  • add the new language to README.md
  • re-build the files (check section below)
  • open a Pull request. Make sure you include everything needed in the pull request (check below)

@MihaiValentin
Copy link
Owner

Thanks @turbobit for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants