Fixed issue with Arabic where only a single expansion character was being removed during stemming #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brendon1982
commented
May 22, 2022
brendon1982
commented
- Describe in detail what you did and why you did it
- What you did: I fixed issue with Arabic where only a single expansion character was being removed during stemming. All expansion characters are now removed.
- Why you did it: The expansion character is only for aesthetic purposes and does not change the meaning of the word. There is no limit to the number of expansion characters a word can have, so when only one is removed instead of all of them, you end up with many versions of the same word in the inverted index, each with a different amount of expansions.
- Add tests. The more the better
- with at least 1 scenario in case of a bug-fix and 4 scenarios in case of a new language
- Don't open a Pull request for more unrelated topics. (eg a bug-fix, a new language, and few changes to stemming for existing languages in a single pull request)
…eing removed during stemming. All expansion characters are now removed.
…+ regex for replacing all occurrences of expansion character as it is compatible with more JS environments.
|
Thanks for the contribution @brendon1982 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.