Skip to content

[JitDiff X64] [EgorBo] Optimize Dictionary.FindValue for constant keys (no c ... #1208

@MihuBot

Description

@MihuBot

Job completed in 15 minutes 39 seconds (remote runner delay: 39 seconds).
dotnet/runtime#117427

Diffs

Found 83 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 40845302
Total bytes of diff: 40845208
Total bytes of delta: -94 (-0.00 % of base)
Total relative delta: 0.58
    diff is an improvement.
    relative diff is a regression.


Total byte diff includes -127 bytes from reconciling methods
	Base had    1 unique methods,      127 unique bytes
	Diff had    0 unique methods,        0 unique bytes

Top file improvements (bytes):
         -94 : System.Private.CoreLib.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method regressions (bytes):
          23 (5.18 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.Dictionary`2[System.Numerics.Vector`1[float],System.Nullable`1[int]]:FindValue(System.Numerics.Vector`1[float]):byref:this (FullOpts)
           5 (26.32 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalIgnoreCaseComparer:Equals(System.String,System.String):bool:this (FullOpts)
           5 (26.32 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.RandomizedStringEqualityComparer+OrdinalIgnoreCaseComparer:Equals(System.String,System.String):bool:this (FullOpts)

Top method improvements (bytes):
        -127 (-100.00 % of base) : System.Private.CoreLib.dasm - System.String:EqualsOrdinalIgnoreCase(System.String,System.String):bool (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
           5 (26.32 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalIgnoreCaseComparer:Equals(System.String,System.String):bool:this (FullOpts)
           5 (26.32 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.RandomizedStringEqualityComparer+OrdinalIgnoreCaseComparer:Equals(System.String,System.String):bool:this (FullOpts)
          23 (5.18 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.Dictionary`2[System.Numerics.Vector`1[float],System.Nullable`1[int]]:FindValue(System.Numerics.Vector`1[float]):byref:this (FullOpts)

Top method improvements (percentages):
        -127 (-100.00 % of base) : System.Private.CoreLib.dasm - System.String:EqualsOrdinalIgnoreCase(System.String,System.String):bool (FullOpts) (1 base, 0 diff methods)

4 total methods with Code Size differences (1 improved, 3 regressed), 247909 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions