Skip to content

[JitDiff X64] [EgorBo] Remove redundant pinning over static fields/RVA #1485

@MihuBot

Description

@MihuBot

Job completed in 17 minutes 18 seconds (remote runner delay: 25 seconds).
dotnet/runtime#119674

Diffs

Found 101 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 41693632
Total bytes of diff: 41693244
Total bytes of delta: -388 (-0.00 % of base)
Total relative delta: -1.35
    diff is an improvement.
    relative diff is an improvement.


Top file regressions (bytes):
         140 : System.Data.Common.dasm (0.01 % of base)
          28 : System.Private.Xml.dasm (0.00 % of base)

Top file improvements (bytes):
        -329 : System.Private.CoreLib.dasm (-0.00 % of base)
         -66 : System.Net.Sockets.dasm (-0.02 % of base)
         -64 : System.IO.Hashing.dasm (-0.24 % of base)
         -44 : System.Console.dasm (-0.05 % of base)
         -28 : System.Reflection.Metadata.dasm (-0.01 % of base)
         -25 : System.Net.Quic.dasm (-0.02 % of base)

8 total files with Code Size differences (6 improved, 2 regressed), 252 unchanged.

Top method regressions (bytes):
         140 (27.67 % of base) : System.Data.Common.dasm - System.Data.SqlTypes.SqlDateTime:.cctor() (FullOpts)
          28 (14.97 % of base) : System.Private.Xml.dasm - System.Xml.Schema.FacetsChecker:Power(int,int):System.Decimal (FullOpts)

Top method improvements (bytes):
         -84 (-10.54 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:DetermineIdentityAndInner(nint,nint,int,byref,byref,byref) (FullOpts)
         -66 (-47.48 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.UnixDomainSocketEndPoint:.cctor() (FullOpts)
         -54 (-7.54 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ReferenceTrackerHost:IReferenceTrackerHost_GetTrackerTarget(nint,nint,ptr):int (FullOpts)
         -44 (-2.15 % of base) : System.Console.dasm - System.ConsolePal:EnsureInitializedCore() (FullOpts) (2 methods)
         -40 (-5.85 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:ComWeakRefToObject(nint,System.Object):System.Object (FullOpts)
         -38 (-8.17 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper:Create(nint,nint,System.Runtime.InteropServices.ComWrappers,System.Object,int,byref):System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper (FullOpts)
         -36 (-31.58 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHashShared:DeriveSecretFromSeed(ptr,ulong) (FullOpts)
         -34 (-4.68 % of base) : System.Private.CoreLib.dasm - System.Convert:ConvertToBase64Array(ptr,ptr,int,int,bool):int (FullOpts)
         -31 (-8.88 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInstance(System.Object,byref):bool (FullOpts)
         -28 (-17.61 % of base) : System.Reflection.Metadata.dasm - System.Reflection.PortableExecutable.PEBuilder:WritePESignature(System.Reflection.Metadata.BlobBuilder) (FullOpts)
         -26 (-5.63 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInterfaceDispatch(nint):ptr (FullOpts)
         -25 (-4.68 % of base) : System.Net.Quic.dasm - System.Net.Quic.MsQuicApi:.ctor(ptr):this (FullOpts)
         -20 (-10.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.RuntimeEventSourceHelper:GetCpuUsage():double (FullOpts)
         -14 (-5.47 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash128:HashLengthOver240(ptr,uint,ulong):System.IO.Hashing.XxHash128+Hash128 (FullOpts)
         -14 (-6.70 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash3:HashLengthOver240(ptr,uint,ulong):ulong (FullOpts)
          -2 (-0.35 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.Marshalling.ComVariant:Create[System.__Canon](System.__Canon):System.Runtime.InteropServices.Marshalling.ComVariant (FullOpts)

Top method regressions (percentages):
         140 (27.67 % of base) : System.Data.Common.dasm - System.Data.SqlTypes.SqlDateTime:.cctor() (FullOpts)
          28 (14.97 % of base) : System.Private.Xml.dasm - System.Xml.Schema.FacetsChecker:Power(int,int):System.Decimal (FullOpts)

Top method improvements (percentages):
         -66 (-47.48 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.UnixDomainSocketEndPoint:.cctor() (FullOpts)
         -36 (-31.58 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHashShared:DeriveSecretFromSeed(ptr,ulong) (FullOpts)
         -28 (-17.61 % of base) : System.Reflection.Metadata.dasm - System.Reflection.PortableExecutable.PEBuilder:WritePESignature(System.Reflection.Metadata.BlobBuilder) (FullOpts)
         -20 (-10.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.RuntimeEventSourceHelper:GetCpuUsage():double (FullOpts)
         -84 (-10.54 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:DetermineIdentityAndInner(nint,nint,int,byref,byref,byref) (FullOpts)
         -31 (-8.88 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInstance(System.Object,byref):bool (FullOpts)
         -38 (-8.17 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper:Create(nint,nint,System.Runtime.InteropServices.ComWrappers,System.Object,int,byref):System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper (FullOpts)
         -54 (-7.54 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ReferenceTrackerHost:IReferenceTrackerHost_GetTrackerTarget(nint,nint,ptr):int (FullOpts)
         -14 (-6.70 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash3:HashLengthOver240(ptr,uint,ulong):ulong (FullOpts)
         -40 (-5.85 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:ComWeakRefToObject(nint,System.Object):System.Object (FullOpts)
         -26 (-5.63 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInterfaceDispatch(nint):ptr (FullOpts)
         -14 (-5.47 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash128:HashLengthOver240(ptr,uint,ulong):System.IO.Hashing.XxHash128+Hash128 (FullOpts)
         -25 (-4.68 % of base) : System.Net.Quic.dasm - System.Net.Quic.MsQuicApi:.ctor(ptr):this (FullOpts)
         -34 (-4.68 % of base) : System.Private.CoreLib.dasm - System.Convert:ConvertToBase64Array(ptr,ptr,int,int,bool):int (FullOpts)
         -44 (-2.15 % of base) : System.Console.dasm - System.ConsolePal:EnsureInitializedCore() (FullOpts) (2 methods)
          -2 (-0.35 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.Marshalling.ComVariant:Create[System.__Canon](System.__Canon):System.Runtime.InteropServices.Marshalling.ComVariant (FullOpts)

18 total methods with Code Size differences (16 improved, 2 regressed), 250552 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions