Find @RequestBody annotations by argument index instead of type (sm…

…allrye#1994) Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar · Sep 30, 2024 · d281b9b · d281b9b
1 parent 1630644
commit d281b9b
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 3 deletions.
diff --git a/core/src/main/java/io/smallrye/openapi/runtime/io/parameters/RequestBodyIO.java b/core/src/main/java/io/smallrye/openapi/runtime/io/parameters/RequestBodyIO.java
@@ -5,6 +5,7 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.stream.Collectors;
+import java.util.stream.IntStream;
 import java.util.stream.Stream;
 
 import org.eclipse.microprofile.openapi.models.media.Content;
@@ -49,9 +50,8 @@ public RequestBodyIO(IOContext<V, A, O, AB, OB> context, ContentIO<V, A, O, AB,
 
     Stream<AnnotationInstance> getAnnotations(MethodInfo method, DotName annotation) {
         Stream<AnnotationInstance> methodAnnos = Stream.of(scannerContext().annotations().getAnnotation(method, annotation));
-        Stream<AnnotationInstance> paramAnnos = method.parameterTypes()
-                .stream()
-                .map(p -> scannerContext().annotations().getMethodParameterAnnotation(method, p, annotation));
+        Stream<AnnotationInstance> paramAnnos = IntStream.range(0, method.parametersCount())
+                .mapToObj(p -> scannerContext().annotations().getMethodParameterAnnotation(method, p, annotation));
 
         return Stream.concat(methodAnnos, paramAnnos)
                 .filter(Objects::nonNull);

diff --git a/extension-jaxrs/src/test/java/io/smallrye/openapi/runtime/scanner/RequestBodyScanTests.java b/extension-jaxrs/src/test/java/io/smallrye/openapi/runtime/scanner/RequestBodyScanTests.java
@@ -3,6 +3,7 @@
 import java.io.IOException;
 import java.util.HashMap;
 
+import org.eclipse.microprofile.openapi.annotations.parameters.Parameter;
 import org.eclipse.microprofile.openapi.annotations.parameters.RequestBody;
 import org.eclipse.microprofile.openapi.models.OpenAPI;
 import org.jboss.jandex.Index;
@@ -104,4 +105,22 @@ public void addBar(@jakarta.validation.constraints.NotEmpty String foo) {
         }
         test("params.request-body-constraints.json", Resource.class);
     }
+
+    @Test
+    void testResponseAnnotationUsed() throws IOException, JSONException {
+        @jakarta.ws.rs.Path("foo")
+        class FooApi {
+            @jakarta.ws.rs.PUT
+            @jakarta.ws.rs.Path("{name}/bar")
+            @jakarta.ws.rs.Consumes("text/plain")
+            @jakarta.ws.rs.Produces("application/json")
+            public jakarta.ws.rs.core.Response putDescription(
+                    @Parameter(description = "The name", required = true) @jakarta.ws.rs.PathParam("name") String name,
+                    @RequestBody(description = "The description", required = true) String description) {
+                return null;
+            }
+        }
+
+        assertJsonEquals("params.request-body-annotation-on-arg.json", FooApi.class);
+    }
 }
diff --git a/.../resources/io/smallrye/openapi/runtime/scanner/params.request-body-annotation-on-arg.json b/.../resources/io/smallrye/openapi/runtime/scanner/params.request-body-annotation-on-arg.json
@@ -0,0 +1,34 @@
+{
+  "openapi" : "3.1.0",
+  "paths" : {
+    "/foo/{name}/bar" : {
+      "put" : {
+        "parameters" : [ {
+          "name" : "name",
+          "in" : "path",
+          "description" : "The name",
+          "required" : true,
+          "schema" : {
+            "type" : "string"
+          }
+        } ],
+        "requestBody" : {
+          "description" : "The description",
+          "content" : {
+            "text/plain" : {
+              "schema" : {
+                "type" : "string"
+              }
+            }
+          },
+          "required" : true
+        },
+        "responses" : {
+          "200" : {
+            "description" : "OK"
+          }
+        }
+      }
+    }
+  }
+}