Made CommonJS the first branch of the export if statement

[johnnyreilly]

Hi!

This recent PR added a named commonjs export for Big. @googol subsequently amended the DefinitelyTyped definitions to cater for this.

Essentially the goal of his changes was to move usage in a more es6 direction; namely making this legitimate:

import { Big } from 'big.js';
const lookABigJs = new Big(1);

That's great, however webpack picks up the first exported branch it can when Big is exported. So it picks up the AMD export not the CommonJS export. You can work around this in webpack by deactivating AMD imports but that's somewhat brute force.

Rather than doing that would you consider flipping the export order as I have done in this PR? So CommonJS is the first branch and AMD is the second. This will resolve issues for Big users of webpack with TypeScript in a hopefully "futurish" fashion.

If you're interested in the context for this then read a really long post here:

microsoft/TypeScript#18791

PS As an aside I updated the version number in line with the package.json.

[googol]

Another possibility would be to remove the module.exports.Big = Big line and add Big.Big = Big on line 1130. That way all branches would have the same export shape, and no old functionality would be disturbed.

The AMD - commonjs - global order comes from the UMD templates directly, and breaking the order might confuse others.

[johnnyreilly]

Sounds good - do you want to submit a PR to replace this one?

[googol]

Sure

[MikeMcl]

This should be resolved with v4.0.0 which I've just pushed.

[johnnyreilly]

Thanks! I'll give it a test today

[googol]

4.0.0 looks good! I'll make a PR for the typings as some of the config variables changed too.

[johnnyreilly]

Sweet - thanks! Give me a shout when you raise the pr and I'll review it

[johnnyreilly]

Typings upgraded here: DefinitelyTyped/DefinitelyTyped#20096 and now released on npm - nice work @MikeMcl and @googol!