Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strangeness in "minimum" method #344

Closed
iKBAHT opened this issue Apr 19, 2023 · 2 comments
Closed

Strangeness in "minimum" method #344

iKBAHT opened this issue Apr 19, 2023 · 2 comments

Comments

@iKBAHT
Copy link

iKBAHT commented Apr 19, 2023

Actual:
BigNumber.minimum(0, -0) is 0

Expected
BigNumber.minimum(0, -0) is -0

Interesting that BigNumber.minimum(-0, 0) works just expected (-0)

Online exampe
@MikeMcl
Copy link
Owner

MikeMcl commented Apr 20, 2023

Good find.
I should have had a test case checking that. No doubt maximum has the same issue.
I'll apply a fix presently.
Thank you for the report.

MikeMcl added a commit that referenced this issue Aug 28, 2023
@MikeMcl
[BUGFIX] #344 minumum(0, -0) should be -0
981a8a9
@MikeMcl
Copy link
Owner

MikeMcl commented Aug 28, 2023

Fixed in v9.1.2.

@MikeMcl MikeMcl closed this as completed Aug 28, 2023
@MikeMcl MikeMcl mentioned this issue Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeMcl @iKBAHT