change return type from "BigNumber" to "this" #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard-coded return type "BigNumber" prevents subclasses from working correctly with TypeScript types when superclass methods are called.
See #368, this PR closes #368
Note: I didn't change the return type of
static isBigNumber(value: any): value is BigNumber;
because its name implies checking whether the instance is a specificallyBigNumber
. Also, it works in subclasses as expected because all subclasses are also instances ofBigNumber
.