Update Parser_expressions.cpp #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 'always@( *)' lexed as '@' '(' '*,' , there will be a error for the parser. The commit can correct the error.
| @@ -1135,6 +1135,13 @@ TimingControlSyntax* Parser::parseTimingControl() { | |||
| expect(TokenKind::CloseParenthesis)); | |||
| } | |||
|
|
|||
| // Special case since @(*) will be lexed as '@' '(' '*)' | |||
| if (peek(TokenKind::StarCloseParenthesis)) { | |||
| auto startclosePara = consume(); | |||
There was a problem hiding this comment.
Typo here, should be something like starCloseParen not "start"
|
Also it would be good to add a test that exercises this. Probably something simple in ExpressionParsingTests.cpp |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 186 186
Lines 43172 43180 +8
=======================================
+ Hits 39348 39356 +8
Misses 3824 3824
Continue to review full report at Codecov.
|
|
Thanks for suggestions. I have corrected the typo and added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 'always@( )' lexed as '@' '(' ',' , there will be a error for the parser. The commit can correct the error.