search for interface files when using -y #752
Conversation
AndrewNolte
force-pushed
the
fix-intf-lookup
branch
from
5630ea0 to
56e5ef4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 91.42% 91.23% -0.19%
==========================================
Files 185 187 +2
Lines 44388 44887 +499
==========================================
+ Hits 40580 40954 +374
- Misses 3808 3933 +125
... and 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
||
| for (auto bd : meta.interfacePorts) { | ||
| std::string_view name = bd->nameOrKeyword.valueText(); | ||
| if (knownNames.find(name) == knownNames.end()) |
There was a problem hiding this comment.
You should check that name is not empty here. Also I think you need to check that the name token is not actually the interface keyword, since that's not actually the name of an interface to load.
There was a problem hiding this comment.
I took out the interface keyword check bc of the Parser change. I don't think the name will every be empty right?
There was a problem hiding this comment.
I think you still need those checks because of the reconstruction case in ParserMetadata.cpp, which will apply to all InterfacePortHeaders and not just the specific code path in parsePortHeader. That check can either be here or in ParserMetadata.cpp.
No description provided.