GD-120: Fix signal 11 crash when execute tests via GdUnitCmdTool
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why Running the `GdUnitCmdTool` ends with an signal 11 and many orphan resource detected # What - fixed the signal 11 by (i would say is a Godot core bug) by: - moving the func `assert_failed_at` to another posision (very strange findings) - using typed array on `load_testsuites()` - fix some orphan issues around singleton implementation - centralize code to finaly cleanup in new `quit` function to avoid orphan nodes - format touched code according to code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Running the
GdUnitCmdToolends with an signal 11 and many orphan resource detectedWhat
assert_failed_atto another posision (very strange results, it crashed for no reason)load_testsuites()quitfunction to avoid orphan nodesNote
It still detects orphan nodes see: godotengine/godot#68009