GD-128: Update GdUnit core to work with Godot.RC5 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why With RC3, RC4, RC3 some regressions are introduced and needs to be addapt to get GdUnit4 running # What - fix bug in releasing internal memory store - fix function doubling according to fixed issue (godotengine/godot#73046) - remove custom `is_instanceof` and replace it by new engine function `is_instance_of` - do code formattings - use new signal code style to connect/disconnect - use workaround for `GlobalScript` enums (godotengine/godot#73835) - use workaround for `Timer.timeout.connect` (godotengine/godot#73889) - use workarount for `Callable.get_method()` (godotengine/godot#73052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With RC3, RC4, RC3 some regressions are introduced and needs to be addapt to get GdUnit4 running
What
GlobalScriptenum as return type ends up in a compile error godotengine/godot#73046)is_instanceofand replace it by new engine functionis_instance_ofGlobalScriptenums (Godot 4.0 RC3class_get_enum_constantsnot working forGlobalScopeenums godotengine/godot#73835)Timer.timeout.connect(Godot 4.0 RC3 to RC5: breakstimer.connect(), the program is stopped forever godotengine/godot#73889)Callable.get_method()(get_method() is not returning the name of the lambda function godotengine/godot#73052)