Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in "scanned" in code and in prints #602

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fixed typo in "scanned" in code and in prints #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions addons/gdUnit4/bin/GdUnitCmdTool.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,9 @@ class CLIRunner:
var ts_scanner := GdUnitTestSuiteScanner.new()
for as_resource_path in to_execute.keys() as Array[String]:
var selected_tests: PackedStringArray = to_execute.get(as_resource_path)
var scaned_suites := ts_scanner.scan(as_resource_path)
skip_test_case(scaned_suites, selected_tests)
test_suites_to_process.append_array(scaned_suites)
var scanned_suites := ts_scanner.scan(as_resource_path)
skip_test_case(scanned_suites, selected_tests)
test_suites_to_process.append_array(scanned_suites)
skip_suites(test_suites_to_process, config)
return test_suites_to_process

Expand Down
8 changes: 4 additions & 4 deletions addons/gdUnit4/src/core/GdUnitRunner.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,15 @@ func load_test_suits() -> Array[Node]:
var _scanner := GdUnitTestSuiteScanner.new()
for resource_path :String in to_execute.keys():
var selected_tests :PackedStringArray = to_execute.get(resource_path)
var scaned_suites := _scanner.scan(resource_path)
_filter_test_case(scaned_suites, selected_tests)
test_suites += scaned_suites
var scanned_suites := _scanner.scan(resource_path)
_filter_test_case(scanned_suites, selected_tests)
test_suites += scanned_suites
return test_suites


func gdUnitInit() -> void:
#enable_manuall_polling()
send_message("Scaned %d test suites" % _test_suites_to_process.size())
send_message("Scanned %d test suites" % _test_suites_to_process.size())
var total_count := _collect_test_case_count(_test_suites_to_process)
_on_gdunit_event(GdUnitInit.new(_test_suites_to_process.size(), total_count))
if not GdUnitSettings.is_test_discover_enabled():
Expand Down
6 changes: 3 additions & 3 deletions addons/gdUnit4/test/core/GdUnitTestSuiteScannerTest.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ func test_scan_by_inheritance_class_name() -> void:
.contains_same_exactly_in_any_order([&"test_foo2", &"test_foo1"])
assert_array(test_suites[2].get_children()).extract("name")\
.contains_same_exactly_in_any_order([&"test_foo3", &"test_foo2", &"test_foo1"])
# finally free all scaned test suites
# finally free all scanned test suites
for ts in test_suites:
ts.free()

Expand All @@ -313,7 +313,7 @@ func test_scan_by_inheritance_class_path() -> void:
tuple("ExtendedTest","res://addons/gdUnit4/test/core/resources/scan_testsuite_inheritance/by_class_path/ExtendedTest.gd", [&"test_foo2", &"test_foo1"]),
tuple("ExtendsExtendedTest", "res://addons/gdUnit4/test/core/resources/scan_testsuite_inheritance/by_class_path/ExtendsExtendedTest.gd", [&"test_foo3", &"test_foo2", &"test_foo1"])
])
# finally free all scaned test suites
# finally free all scanned test suites
for ts in test_suites:
ts.free()

Expand Down Expand Up @@ -375,7 +375,7 @@ func test_scan_test_suite_without_tests() -> void:

assert_array(test_suites).has_size(1)
assert_that(test_suites[0].get_child_count()).is_equal(0)
# finally free all scaned test suites
# finally free all scanned test suites
for ts in test_suites:
ts.free()

Expand Down