Pylint if/elif/else, returns and isinstance comparisons #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically around if/else improvements and conditional checks. All tests pass.
|
Sorry been a bit busy. I'll check this next weekend at the latest. Thanks again for cleaning the project! This is well appreciated. |
|
No hurry or worries, I'm learning a lot by working through these, and hopefully they're somewhat useful. |
|
Sorry for taking eternity with this, got distracted with learning about event-driven design (in order to make Rocketry to support its patterns). I'll try to merge this today evening. |
|
Thanks again for the PR! Looks indeed good and especially the tests previously had some really odd patterns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more pylint stuff, cleaning up unnecessarily complex if/elif/else branches, and overly complex boolean / instance comparisons. Hope it helps. I'm unsure how to trigger the code coverage you did last time.