Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add SchedulerLogger #156

Merged
merged 3 commits into from
Nov 27, 2022
Merged

ENH: Add SchedulerLogger #156

merged 3 commits into from
Nov 27, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Nov 27, 2022

SchedulerLogger is to TaskLogger:

from rocketry.args import TaskLogger, SchedulerLogger
@app.setup()
def setup_app(task_logger=TaskLogger(), sched_logger=SchedulerLogger()):
    sched_logger.addHandler(...)

@Miksus Miksus added the enhancement New feature or request label Nov 27, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 95.36% // Head: 95.36% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d5607a4) compared to base (8384fab).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          80       80           
  Lines        4656     4660    +4     
=======================================
+ Hits         4440     4444    +4     
  Misses        216      216           
Impacted Files Coverage Δ
rocketry/args/builtin.py 98.22% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus Miksus merged commit 7dbd1c0 into master Nov 27, 2022
@Miksus Miksus deleted the dev/add_scheduler_logger branch November 27, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants