ENH: Option to silence log errors #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also now silences errors in logging
Miksus
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 91.14% 91.39% +0.25%
==========================================
Files 88 89 +1
Lines 4368 4474 +106
==========================================
+ Hits 3981 4089 +108
+ Misses 387 385 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Also reverted silence_task_prerun.
Now status is set after logging.
If silence_task_logging is not true
Now shutdown errors should be correctly raised
CI got stuck.
Perhaps the task just ran multiple times (and the final was success)
testing whether CI gets stuck on silence_task_logging=True
Moved log_running also from async task outside of task execution to make sure failure occurs even if only log_running fails (and not log_success)
With the exception of logging to run.
Miksus
commented
Sep 1, 2022
rocketry/session.py
Outdated
| @@ -50,7 +51,8 @@ class Config: | |||
| task_logger_basename: str = "rocketry.task" | |||
| scheduler_logger_basename: str = "rocketry.scheduler" | |||
|
|
|||
| silence_task_prerun: bool = False # Whether to silence errors occurred in setting a task to run | |||
| silence_task_prerun: Optional[bool] = None # Whether to silence errors occurred in setting a task to run | |||
There was a problem hiding this comment.
This is probably incorrect. Should not be optional and by default False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
silence_task_loggingconfig option (log failures won't crash scheduler if true)