Injectable null safety #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Migrating injectable_generator requires dart-lang/source_gen#493 and dart-lang/build#2920 (in progress: dart-lang/build#2996) |
|
Hey @britannio for some reason I didn't get notified about the this pull request. anyways I'm refactoring the code generator to use code_builder library before I put in work in migration as the current code is a bit messy. |
|
Sounds good! |
|
@britannio It's already done, Thanks for your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step towards addressing #170 and #147
I'm curious as to why this isn't split into two separate classes?
https://github.com/Milad-Akarie/injectable/blob/master/injectable/lib/src/injectable_annotations.dart#L98-L112