Skip to content

Commit

Permalink
fix: remove return-value in vitePluginExternalize config function whi…
Browse files Browse the repository at this point in the history
…ch caused duplicate esbuild plugins (#114)
  • Loading branch information
rhlin authored Jul 24, 2024
1 parent d06558e commit c7cc8a6
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-jokes-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vite-plugin-externalize-dependencies": patch
---

fix duplicated esbuild plugins issue
22 changes: 9 additions & 13 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,27 +128,23 @@ const vitePluginExternalize = (options: PluginOptions): Plugin => ({
name: "vite-plugin-externalize",
enforce: "pre",
apply: "serve",
config: (config: UserConfig): UserConfig | undefined => {
const modifiedConfiguration = { ...config };

modifiedConfiguration.optimizeDeps ??= {};
modifiedConfiguration.optimizeDeps.esbuildOptions ??= {};
modifiedConfiguration.optimizeDeps.esbuildOptions.plugins ??= [];
config: (config: UserConfig): Omit<UserConfig, "plugins"> | null | void => {
config.optimizeDeps ??= {}; // eslint-disable-line no-param-reassign
config.optimizeDeps.esbuildOptions ??= {}; // eslint-disable-line no-param-reassign
config.optimizeDeps.esbuildOptions.plugins ??= []; // eslint-disable-line no-param-reassign

// Prevent the plugin from being inserted multiple times
const pluginName = "externalize";
const isPluginAdded =
modifiedConfiguration.optimizeDeps.esbuildOptions.plugins.some(
(plugin) => plugin.name === pluginName,
);
const isPluginAdded = config.optimizeDeps.esbuildOptions.plugins.some(
(plugin: EsbuildPlugin) => plugin.name === pluginName,
);

if (!isPluginAdded) {
modifiedConfiguration.optimizeDeps.esbuildOptions.plugins.push(
config.optimizeDeps.esbuildOptions.plugins.push(
esbuildPluginExternalize(options.externals),
);
}

return modifiedConfiguration;
return null;
},
configResolved: (resolvedConfig: ResolvedConfig) => {
// Plugins are read-only, and should not be modified,
Expand Down

0 comments on commit c7cc8a6

Please sign in to comment.