Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paper "Discovery of a Planar Black Hole Mass Scaling Relation for Spiral Galaxies" #437

Merged
merged 12 commits into from
Oct 11, 2023

Conversation

ZehaoJin
Copy link
Contributor

@ZehaoJin ZehaoJin commented Oct 3, 2023

I uploaded both a .gif animation and a .pdf plot. Use the plot instead of animation doesn't work.

@MilesCranmer
Copy link
Owner

Hi @ZehaoJin,
Thanks so much for submitting this! Unfortunately the gif file is 10 MB which would increase the repo size by quite a bit will slow down the page loading times. Could you please only include the image? I think you can convert the pdf to an svg which will also be vectorized and small in size. (But PDFs will not easily display on the web page)
Thanks!
Miles

@ZehaoJin
Copy link
Contributor Author

ZehaoJin commented Oct 3, 2023

Thank you very much! I put a png image instead, it should work now.

@ZehaoJin
Copy link
Contributor Author

ZehaoJin commented Oct 9, 2023

@MilesCranmer Thank you very much! I put a png image instead, it should work now.

@MilesCranmer
Copy link
Owner

Thanks. Do you know what this issue is caused by?

https://results.pre-commit.ci/run/github/295391759/1696357984.nzf76DElTmOZ08A51kO8tw

once all the tests pass I can merge

@ZehaoJin
Copy link
Contributor Author

ZehaoJin commented Oct 9, 2023

@MilesCranmer Thanks for pointing me to the error! Now seems like it passes

docs/papers.yml Outdated Show resolved Hide resolved
@MilesCranmer MilesCranmer merged commit 6abcc15 into MilesCranmer:master Oct 11, 2023
3 checks passed
@MilesCranmer
Copy link
Owner

Thanks again for submitting. Very exciting result and paper by the way!! Let me know if you posted it on twitter or LinkedIn and I'm happy to help share it more widely. It is a super nice application!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants