-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to eager
registry when needed
#765
Fall back to eager
registry when needed
#765
Conversation
eager
flavor of the Julia registry from the Julia Pkg Serverseager
flavor of the Julia registry from the Julia Pkg Servers (but try falling back to conservative
if an exception is encountered)
eager
flavor of the Julia registry from the Julia Pkg Servers (but try falling back to conservative
if an exception is encountered)eager
flavor of the Julia registry from the Julia Pkg Servers (but try falling back to conservative
if an exception is encountered)
9ed3231
to
2538d67
Compare
@MilesCranmer If it fails with Does |
I'm guessing that the answer to this question is yes, based on this line (line 334): But I'm not very familiar with |
I realize that we need to do this in every location where a Pkg operation might be needed. |
So I'll have to refactor this functionality out, to make it easier to call in multiple locations. |
Pull Request Test Coverage Report for Build 12200236348Details
💛 - Coveralls |
…ia Pkg Servers (but try falling back to `conservative` if an exception is encountered)
403531e
to
a40e8c7
Compare
@MilesCranmer I think this is ready for review now. |
for more information, see https://pre-commit.ci
@MilesCranmer Can you enable CI on the new commit? |
eager
flavor of the Julia registry from the Julia Pkg Servers (but try falling back to conservative
if an exception is encountered)eager
registry when needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few changes. Importantly I changed it so that it doesn't change the registry preference by default. Only if it fails to resolve do I switch things to eager
.
What do you think of the edits?
Also, added some unittests |
Thanks @DilumAluthge! |
No description provided.