Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crepe): button type in toolbar #1530

Conversation

TorstenDittmann
Copy link
Contributor

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

  • using the crepe bundle inside a form triggers a submit when a button in the toolbar is pressed
  • the default type of a button is submit, changing it to type button prevents this
  • there are potentially more cases of a missing button type, but didn't wanna explode the scope of this pr

How did you test this change?

  • checked on storybook that crepe stories are rendering and also that type="button" is present

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: e704287

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 0:29am

Copy link

nx-cloud bot commented Oct 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e704287. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Saul-Mirone Saul-Mirone merged commit 6d36b40 into Milkdown:main Oct 8, 2024
4 checks passed
@TorstenDittmann TorstenDittmann deleted the crepe/fix-submit-buttons-in-tooltip branch October 8, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants