Fix bug with ranges larger than 2**31 in buffer.toString() method #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing the bug reported on this issue
When we create buffers larger than 2ˆ31 and try to call toString passing start and end also larger than 2ˆ31 (but still smaller than the size of the buffer), we end up with an ERR_OUT_OF_RANGE.
In this PR, we're adding a unit test to validate this scenario. Initially, this error happens:
We figured out that this error is caused by the bitwise-or operation done to cast "start" and "end" to numbers. This operation only supports positive integers up to 2ˆ31. After, it will truncate and even consider them as negative numbers due to interpreting them as a 2's complement. After changing this to a MathTrunc instead, all tests passed correctly:
