Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review van vereisten uit release v1.1 #106

Merged
merged 26 commits into from
May 22, 2024

Conversation

ruthkoole
Copy link
Collaborator

@ruthkoole ruthkoole commented May 8, 2024

  • links toegevoegd bij bronvermelding
  • zorgen dat bijbehorende maatregelen automatisch worden toegevoegd
  • tekstuele wijzigingen

Beschrijf jouw aanpassingen

Bij welk issue hoort deze pull-request?

Checklist before requesting a review

  • Ik heb de contributing guidelines van deze repository gelezen en gevolgd.
  • Ik heb mijn aanpassingen gecheckt op spelfouten.
  • Als ik gebruik heb gemaakt van links, dan heb ik gecheckt of deze werken.
  • Ik heb gebruik gemaakt van de templates en formats van het algoritmekader.
  • Deze pull-request gaat naar de juiste branch (in principe mergen we eerst naar de branch release alvorens te mergen naar de main branch).

- links toegevoegd bij bronvermelding
- zorgen dat bijbehorende maatregelen automatisch worden toegevoegd
- tekstuele wijzigingen
Copy link

github-actions bot commented May 8, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-22 07:47 UTC

@ruthkoole ruthkoole changed the title review van vereiste algoritmeregister review van vereisten uit release 1 May 8, 2024
@ruthkoole ruthkoole changed the title review van vereisten uit release 1 review van vereisten uit release v1.1 May 8, 2024
@ruthkoole ruthkoole requested a review from BartdeVisser May 16, 2024 08:24
@ruthkoole ruthkoole changed the base branch from main to release May 17, 2024 12:04
@ruthkoole ruthkoole marked this pull request as ready for review May 17, 2024 12:18
ruthkoole and others added 2 commits May 21, 2024 16:59
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jasper van der Heide <19666278+jaspervanderheide@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Floor Terra <floort@gmail.com>
@ruthkoole ruthkoole linked an issue May 21, 2024 that may be closed by this pull request
@ruthkoole ruthkoole added this to the Release v1.2 milestone May 21, 2024
Copy link
Collaborator

@BartdeVisser BartdeVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eén reviewpunt.

docs/vereisten/algoritmeregister.md Outdated Show resolved Hide resolved
@ruthkoole ruthkoole merged commit 8abfdcc into release May 22, 2024
1 check passed
@ruthkoole ruthkoole deleted the release-v1.2/review-eerste-vereisten branch May 22, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verwerking feedback op basis van Release v1.1
3 participants