Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.3/overzichtspag vereisten maatregelen #151

Merged
merged 11 commits into from
Jul 2, 2024
Merged

Release v1.3/overzichtspag vereisten maatregelen #151

merged 11 commits into from
Jul 2, 2024

Conversation

ruthkoole
Copy link
Collaborator

@ruthkoole ruthkoole commented Jun 17, 2024 •
edited
Loading

Beschrijf jouw aanpassingen

  • duidelijkere overzichtspagina's voor vereisten en maatregelen
  • navigation (linker zijmenu) is uitgeschakeld voor alle vereisten en maatregelen

Bij welk issue hoort deze pull-request?

#140

Checklist before requesting a review

  • Ik heb de contributing guidelines van deze repository gelezen en gevolgd.
  • Ik heb mijn aanpassingen gecheckt op spelfouten.
  • Als ik gebruik heb gemaakt van links, dan heb ik gecheckt of deze werken.
  • Ik heb gebruik gemaakt van de templates en formats van het algoritmekader.
  • Deze pull-request gaat naar de juiste branch (in principe mergen we eerst naar de branch release alvorens te mergen naar de main branch).

@ruthkoole ruthkoole added this to the Release v1.3 milestone Jun 17, 2024
@ruthkoole ruthkoole linked an issue Jun 17, 2024 that may be closed by this pull request
Overzichtspagina's van vereisten en maatregelen aanpassen #140
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-02 09:41 UTC

@ruthkoole ruthkoole changed the base branch from main to release June 17, 2024 06:53
@ruthkoole ruthkoole marked this pull request as ready for review June 24, 2024 19:38
@ruthkoole
Copy link
Collaborator Author

voor een volgende keer moeten we nog kijken naar de volgorde van de vereisten. Wordt nu bepaald op basis van bestandsnaam. Dat is niet ideaal.

noutvandeijck
noutvandeijck requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@noutvandeijck noutvandeijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kleine wijzigingen zoals gefixte links en taalfoutje.

docs/maatregelen/archiveren_vaststellen_documenten.md Outdated Show resolved Hide resolved
docs/maatregelen/leveren_bewijs_niet_schenden_auteursrechten_trainingsdata.md Outdated Show resolved Hide resolved
docs/maatregelen/schending_auteursrechten_output_onderdeel_conceptovereenkomst.md Outdated Show resolved Hide resolved
docs/vereisten/index.md Outdated Show resolved Hide resolved
@ruthkoole ruthkoole mentioned this pull request Jun 26, 2024
Merged
5 tasks
ruthkoole and others added 7 commits June 28, 2024 12:08
@ruthkoole
aanpassen maatregelen pagina
51b949c
@ruthkoole
hide navigation on maatregelen pages and minor changes
66315ed
@ruthkoole
aanpassen aantal kolommen op bouwblok pagina
cccf91c
@ruthkoole
aanpassen vereisten pagina's aan navigatie
bd00305
@ruthkoole @noutvandeijck
Update docs/vereisten/index.md
2f6d7e0 
Co-authored-by: Nout van Deijck <168716911+noutvandeijck@users.noreply.github.com>
@ruthkoole @noutvandeijck
Update docs/maatregelen/schending_auteursrechten_output_onderdeel_con…
d8d01b3 
…ceptovereenkomst.md

Co-authored-by: Nout van Deijck <168716911+noutvandeijck@users.noreply.github.com>
@ruthkoole @noutvandeijck
Update docs/maatregelen/leveren_bewijs_niet_schenden_auteursrechten_t…
5272208 
…rainingsdata.md

Co-authored-by: Nout van Deijck <168716911+noutvandeijck@users.noreply.github.com>
@ruthkoole ruthkoole force-pushed the release-v1.3/overzichtspag-vereisten-maatregelen branch from 3bd2707 to 5272208 Compare June 28, 2024 10:08
@ruthkoole ruthkoole merged commit ffece0f into release Jul 2, 2024
1 check passed
@ruthkoole ruthkoole deleted the release-v1.3/overzichtspag-vereisten-maatregelen branch July 2, 2024 09:41
@ruthkoole ruthkoole mentioned this pull request Jul 2, 2024
Merged
5 tasks
ruthkoole added a commit that referenced this pull request Jul 2, 2024
@ruthkoole @noutvandeijck @BartdeVisser
Release v1.3/overzichtspag vereisten maatregelen (#151)
dbc1569 
Co-authored-by: Nout van Deijck <168716911+noutvandeijck@users.noreply.github.com>
Co-authored-by: BartdeVisser <155545133+BartdeVisser@users.noreply.github.com>
ruthkoole added a commit that referenced this pull request Jul 10, 2024
@ruthkoole @noutvandeijck @BartdeVisser
Release v1.3/overzichtspag vereisten maatregelen (#151)
9ee2d38 
Co-authored-by: Nout van Deijck <168716911+noutvandeijck@users.noreply.github.com>
Co-authored-by: BartdeVisser <155545133+BartdeVisser@users.noreply.github.com>
ruthkoole added a commit that referenced this pull request Jul 10, 2024
@ruthkoole @noutvandeijck @BartdeVisser
Release v1.3/overzichtspag vereisten maatregelen (#151)
d91ce13 
Co-authored-by: Nout van Deijck <168716911+noutvandeijck@users.noreply.github.com>
Co-authored-by: BartdeVisser <155545133+BartdeVisser@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartdeVisser BartdeVisser BartdeVisser left review comments

@noutvandeijck noutvandeijck noutvandeijck approved these changes

@jaspervanderheide jaspervanderheide Awaiting requested review from jaspervanderheide

Assignees

@noutvandeijck noutvandeijck

Labels
None yet
Projects
None yet
Milestone
Release v1.3
Development

Successfully merging this pull request may close these issues.

Overzichtspagina's van vereisten en maatregelen aanpassen
3 participants
@ruthkoole @BartdeVisser @noutvandeijck