Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added styling to home content #219

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Added styling to home content #219

merged 9 commits into from
Aug 14, 2024

Conversation

rubenrouwhof
Copy link
Collaborator

Beschrijf jouw aanpassingen

  • Blocks for content based on overheid.nl styling
  • Babel for version (with extra info on hover)
  • Text color. (No font update yet)

Bij welk issue hoort deze pull-request?

Text from #192 (review)

Checklist before requesting a review

  • Ik heb de contributing guidelines van deze repository gelezen en gevolgd.
  • Ik heb mijn aanpassingen gecheckt op spelfouten.
  • Als ik gebruik heb gemaakt van links, dan heb ik gecheckt of deze werken.
  • Ik heb gebruik gemaakt van de templates en formats van het algoritmekader.

Copy link

github-actions bot commented Aug 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-14 07:27 UTC

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated

<div class="float-container">
<div class="float-child styled-list">
<h3><a href="rollen/index.md" class="show-more">Informatie voor rol</a></h3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3><a href="rollen/index.md" class="show-more">Informatie voor rol</a></h3>
<h3><a href="rollen/" class="show-more">Informatie voor</a></h3>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit linkje werkte bij mij niet. index.md moet volgens mij weg? Het woord 'rol' weggehaald in de titel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruthkoole Ja ik had het juist toegevoegd omdat het linkt(als het werkt) naar de rollen pagina en daar vond ik 'Informatie voor' niet helemaal de lading dekken

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik zou er dan 'Informatie per rol' van maken. Nu vond ik hem ook enigszins gek lezen. (ik kan deze edit helaas niet meer als suggestie in-line plaatsen)

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
rubenrouwhof and others added 9 commits August 14, 2024 09:22
Co-authored-by: Ruth Koole <71120805+ruthkoole@users.noreply.github.com>
Co-authored-by: Ruth Koole <71120805+ruthkoole@users.noreply.github.com>
Co-authored-by: Ruth Koole <71120805+ruthkoole@users.noreply.github.com>
Co-authored-by: Ruth Koole <71120805+ruthkoole@users.noreply.github.com>
Co-authored-by: Ruth Koole <71120805+ruthkoole@users.noreply.github.com>
@ruthkoole ruthkoole merged commit 1c528de into main Aug 14, 2024
1 check passed
@ruthkoole ruthkoole deleted the update-homepage branch August 14, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants