Fix PR comments

PR comments Update README.md Co-authored-by: Laurens Weijs <laurens.weijs@rijksoverheid.nl> Update frontend/src/stores/QuestionStore.ts Co-authored-by: Laurens Weijs <laurens.weijs@rijksoverheid.nl> Update frontend/src/components/SubResult.vue Co-authored-by: Laurens Weijs <laurens.weijs@rijksoverheid.nl>
MinBZK · Nov 11, 2024 · dab5217 · dab5217
1 parent 777c38a
commit dab5217
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -100,7 +100,7 @@ Let op: de diagrammen kunnen het beste in Chrome, Safari of Microsoft Edge worde
 
 Om door de beslishulp te lopen is een visualizatie tool gemaakt. Met deze tool kunt u door de vragen lopen. De frontend is beschikbaar op deze [website](https://ai-act-decisiontree.apps.digilab.network).
 
-### Frontend locaal draaien
+### Frontend lokaal draaien
 
 Om de development omgeving te standaardiseren maken we gebruik van [devcontainers](https://code.visualstudio.com/docs/devcontainers/containers#_getting-started).
 

diff --git a/frontend/src/components/SubResult.vue b/frontend/src/components/SubResult.vue
@@ -14,7 +14,7 @@ interface Props {
 
 // Function to check if there are any valid labels in a category
 function hasValidLabelsForCategory(assigned_labels: string[]) {
-  return assigned_labels.some(label => label !== 'nader te bepalen' && label !== 'niet van toepassing')
+  return assigned_labels.some(label => label !== 'nader te bepalen' )
 }
 
 // Filter categories that have valid labels (not 'nader te bepalen' or 'niet van toepassing')

diff --git a/frontend/src/stores/CategoryStore.ts b/frontend/src/stores/CategoryStore.ts
@@ -98,7 +98,6 @@ export const useCategoryStore = defineStore('category', () => {
   function revertCurrentCategory() {
     /**
      * Set the currentCategory back to incomplete when the previousCategory is different
-     * TODO: subcategory?
      */
     // Categories section
     revertCategoryState()
@@ -142,7 +141,6 @@ export const useCategoryStore = defineStore('category', () => {
     previousCategory.value = startCategory
     previousSubCategory.value = startSubCategory
     categoryState.value = JSON.parse(initialCategoryStateString)
-    // subCategoryState.value = JSON.parse(initialSubCategoryStateString)
     categoryTrace.value = []
     subCategoryTrace.value = []
     localStorage.removeItem('currentCategory')

diff --git a/frontend/src/stores/QuestionStore.ts b/frontend/src/stores/QuestionStore.ts
@@ -12,11 +12,15 @@ export const useQuestionStore = defineStore('question', () => {
     "Transparantieverplichting": ["nader te bepalen"]
   }`
 
-  const initialAcceptedDisclaimer = sessionStorage.getItem('acceptedDisclaimer') ?? '0' //TODO: figure out why this is 0
+  const initialAcceptedDisclaimer = sessionStorage.getItem('acceptedDisclaimer') ?? '0'
   const initialAnswers = JSON.parse(localStorage.getItem('answers') ?? '[]')
   const initialLabels = JSON.parse(localStorage.getItem('labels') ?? '{}')
+<<<<<<< HEAD
+  const initialLabelsBySubCategory = JSON.parse(localStorage.getItem('labelsbysubcategoryß') ?? initialLabelsBySubCategoryNTB)
+=======
   const initialLabelsBySubCategory = JSON.parse(localStorage.getItem('labelsbysubcategory') ?? initialLabelsBySubCategoryNTB)
-  const initialQuestionId = localStorage.getItem('currentquestion') ?? '1.2' //TODO: check if this is correct
+>>>>>>> e1268db (Update frontend/src/stores/QuestionStore.ts)
+  const initialQuestionId = localStorage.getItem('currentquestion') ?? '1.2'
   const initialConclusionId = localStorage.getItem('currentconclusion') ?? ''
 
   const AcceptedDisclaimer = ref(String(initialAcceptedDisclaimer))