Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty descriptions #86

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix empty descriptions #86

merged 1 commit into from
Dec 18, 2024

Conversation

ravimeijerrig
Copy link
Contributor

@ravimeijerrig ravimeijerrig commented Dec 18, 2024 •
edited
Loading

Description

In this PR we fix the empty descriptions and explanations in the requirements and measures.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ravimeijerrig ravimeijerrig requested a review from a team as a code owner December 18, 2024 11:12
@ravimeijerrig ravimeijerrig linked an issue Dec 18, 2024 that may be closed by this pull request
Description in measures #87
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

laurensWe
laurensWe approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty annoying that the regex is so specific though, this will probably in the future become again a problem :s

@ravimeijerrig ravimeijerrig merged commit e2f4502 into main Dec 18, 2024
16 checks passed
@ravimeijerrig ravimeijerrig deleted the fix_empty_descriptions branch December 18, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurensWe laurensWe laurensWe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description in measures
2 participants
@ravimeijerrig @laurensWe