Enable proofs in tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will take longer, but we could miss errors, in particular with the modular admin contract.
Changing methods of smart contracts through inheritance is known not to work, so we're defining a new contract providing the same methods instead.
This test that it's not possible to just provide another admin contract in order to bypass permissions.
mitschabaude
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will take longer, but we could miss errors, in particular with the modular admin contract.
This PR does fix an error that was missed with
proofsEnabled=false: with that option, the tests passed even when we were using inheritance to change the admin contract. But it fails if we enable the proofs.