Implement concurrent minting/burning #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using inheritance to change which constructor is used does not work. Instead, we are using a `static` field, which can be set without changing the class.
kantp
force-pushed
the
kantp/concurrent-minting
branch
from
b05c744 to
8ea2b7a
Compare
kantp
force-pushed
the
kantp/concurrent-minting
branch
from
529cf28 to
533241d
Compare
Some tests that assert that something that should not work does indeed not work will fail when we disable proofs in the tests. So we should skip them if `proofsEnabled` is false.
kantp
force-pushed
the
kantp/concurrent-minting
branch
from
cb23a26 to
8542c20
Compare
mitschabaude
approved these changes
May 8, 2024
Comment on lines
+611
to
+613
| it("should not mint too many B tokens using the vanilla admin contract", { | ||
| skip: !proofsEnabled, | ||
| }, async () => { |
There was a problem hiding this comment.
why this is skipped when proofs are disabled?
There was a problem hiding this comment.
Good question! I observed that this test fails when proofs are disabled.
My suspicion is that when proofs are disabled, the verification key of the admin contract is never checked, so you can get away with switching the admin contract. And this test tests that that is prevented (which only works when the proofs are actually constructed and checked).
There was a problem hiding this comment.
Right, that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do this, we remove the total supply (and the check that the circulating supply does not exceed it) from the main contract, and use actions/reducers to update the circulating supply.
Enforcing a limit on the circulating supply will then be the responsibility of the admin contract.