Best practices and recommendations from audit #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clearer that this is a constructor.
Also, switch to `TokenContractV2`.
Otherwise, the values are not checked in a proof and might be invalid.
ymekuria
approved these changes
Jul 17, 2024
| this.paused.set(Bool(false)) | ||
|
|
||
| this.account.tokenSymbol.set(props.symbol) | ||
| this.paused.set(Bool(true)) |
There was a problem hiding this comment.
I'm just curious. Do you set the paused flag in the initialized method as well as here in deploy?
There was a problem hiding this comment.
It's probably superfluous. We urge people to use an atomic deploy, calling the deploy() functions of the admin and token contract, as well as initialize() all in one transaction. But if they don't, we at least want no transactions to happen before initialise() is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.