Skip to content

Conversation

@MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Jun 12, 2023

SUPERSEDED by #427

see https://github.com/o1-labs/docs2/wiki/Markdown-Syntax#adding-videos-in-docs

Description

Instead of the old practice of using a manual thumbnail to specify a youtube link, we add the embedded element directly in our docs. This will improve UX and SEO.

Steps to add an embedded video

If you want to add a youtube video in our docs, we can directly add the iframe HTML in our docs! 😄 To do so, we simply need to do the following:

  1. Go to the youtube video you would link to link
  2. Click Share
    image
  3. Click Embed
    image
  4. Click Copy
    image
  5. Paste the HTML in your clipboard directly in the docs!

Things to note

You can resize the iframe by editing the HTML. For example, in the iframe element, there will be a height and width property. You can change these values to resize how big the iframe element is:

<iframe
  width="900"
  height="550"
  src="https://www.youtube.com/embed/GvwYJDzzI-g"
 ...
></iframe>

@MartinMinkov MartinMinkov requested a review from a team as a code owner June 12, 2023 23:07
@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview Jun 12, 2023 11:07pm

@barriebyron
Copy link
Contributor

@MartinMinkov This method is excellent upgrade to our video embed workflow! Thank you for the quick solution
I see how you changed
https://docs2-git-feat-fix-youtube-links-minadocs.vercel.app/about-mina/what-are-zero-knowledge-proofs

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so good, so fast, so awesome!

@MartinMinkov MartinMinkov merged commit c95a24c into main Jun 13, 2023
@MartinMinkov MartinMinkov deleted the feat/fix-youtube-links branch June 13, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants