-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Adding Steps for 09-recursion tutorial #796
📝 Adding Steps for 09-recursion tutorial #796
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@LuffySama-Dev is attempting to deploy a commit to the o1labs Team on Vercel. A member of the Team first needs to authorize it. |
Hi @barriebyron , As requested in this comment #763 (comment), I have made the changes. Can you please help to review ? Thank You 😃 |
@iregina can you do the first round of review and testing? thank you! |
I ran your code, but came across an issue in the
Question - @LuffySama-Dev Did you also get this issue when you ran this with o1js version 15.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc updates look good @LuffySama-Dev
Our DevRel @iregina is going to run through the steps and we'll get these improvements merged, thank you so much!!
Hi @iregina , Also, I think this file is not actually require, I think it is implementation for Thank You 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @LuffySama-Dev you are very on top of things! I learned to run the code in your PR
(see me dancing?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - went through this in detail with Barrie and Jack!
Hi @barriebyron ,
Good Day!!
I am creating this new PR instead of this old PR #763 as many new changes have been committed in this repo.
I have made all the recommended changes in this PR.
I am still working on the Vote and Rollup so we can keep this PR in draft for couple of days.
I will try to commit all the changes and close it by tomorrow EOD.
You can track changes here:
Changes made:
Upcoming changes:
Issues being resolve here are :
Thank you 😃