Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eta support #2

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Conversation

rahulmutt
Copy link

  • This library doesn't actually use the TypeApplications extension and builds fine without it.
  • Eta currently only has a patch for network-2.6.3.2 and it built fine, so I relaxed the lower bound on network.
  • Added dist to the gitignore because that's where Etlas (and Cabal) build info is stored.

@enolan
Copy link

enolan commented Apr 11, 2019

I'm happy to merge this, but can I ask why you want to compile it with Eta in the first place? It's mostly unmaintained and we're planning to move Coda off of it Soon™.

@enolan enolan merged commit 5588974 into MinaProtocol:master Apr 11, 2019
@rahulmutt rahulmutt deleted the update-build-info branch April 12, 2019 02:33
@rahulmutt
Copy link
Author

rahulmutt commented Apr 12, 2019

Ok cool, I was thinking about making an uberjar for kademlia-haskell so that it becomes easier to install & run across platforms without having to download an entire Nix store. I'll follow MinaProtocol/mina#2211 for any updates then.

@bkase
Copy link
Member

bkase commented Apr 12, 2019

Ah that definitely would have been really helpful! But we’ll likely move off of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants