Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite CI (artifacts): Libp2p helper #5139

Closed
bkase opened this issue Jun 16, 2020 · 1 comment · Fixed by #5009
Closed

Buildkite CI (artifacts): Libp2p helper #5139

bkase opened this issue Jun 16, 2020 · 1 comment · Fixed by #5009
Assignees
@O1ahmad
Labels
Size: S ~ 0.5 wks Taskforce Iterate (C)

Comments

@bkase
Copy link
Member

bkase commented Jun 16, 2020 •
edited
Loading

First part of #4806
@bkase bkase assigned bkase and O1ahmad and unassigned bkase Jun 16, 2020
@O1ahmad O1ahmad linked a pull request Jun 29, 2020 that will close this issue
Feature/ci buildkite unit tests #5009
Merged
2 tasks
@O1ahmad
Copy link
Contributor

O1ahmad commented Jun 29, 2020

Resolved by #5009.

Note: unit--dev tests currently explicitly build libp2p_helper via make build. Due to this, separate CircleCI libp2p_helper step is redundant and has currently been excluded from the Buildkite Unit pipeline though this hasn't seemed to affect the non-consensus unit tests.

However, libp2p_helper build may be removed from make build path in order to allow for caching of libp2p_helper via previously planned and implemented libp2p-helper build step.

@O1ahmad O1ahmad closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@O1ahmad O1ahmad

Labels
Size: S ~ 0.5 wks Taskforce Iterate (C)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/ci buildkite unit tests MinaProtocol/mina
2 participants
@bkase @O1ahmad