Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildkite CI (artifacts): Refactor such that there is a distinct step end when the build finishes #5142

Closed
bkase opened this issue Jun 16, 2020 · 3 comments

Comments

@bkase
Copy link
Member

bkase commented Jun 16, 2020

This way later jobs can depend on this part of the artifact build

@bkase bkase changed the title Buildkite CI (artifacts): Runtime genesis output + runtime genesis 10k + upload Buildkite CI (artifacts): Refactor such that there is a distinct step end when the build finishes Jul 9, 2020
@O1ahmad O1ahmad self-assigned this Jul 29, 2020
@O1ahmad
Copy link
Contributor

O1ahmad commented Aug 14, 2020

May make sense to convert Artifact.dhall into a helper Command (like OpamInit or DockerArtifact) to be imported and depended on by other jobs (e.g. integration framework tests). These jobs could then just depend on the command helper's step key after inclusion.

@O1ahmad
Copy link
Contributor

O1ahmad commented Aug 14, 2020

Also as @lk86 pointed out during a discussion artifact builds can already be depended on using the key defined in the job (job end should signal proper readiness of the artifact to consume) and with the provision that Artifact.dhall always runs with any change (which it should now). Only downside here is that the artifact steps are needed (build et all) on every change though this could be avoided with short-circuiting logic.

@O1ahmad
Copy link
Contributor

O1ahmad commented Aug 17, 2020

Dependency keys:

  • Debian package upload: _Artifacts-artifacts-build (name: Artifact, key: artifacts-build)
  • Docker artifact build/push: _DockerArtifact-docker-artifact (name: DockerArtifact, key: docker-artifact)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants