Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] buildkite/port over block production test #5603

Closed
wants to merge 63 commits into from
Closed

[WIP] buildkite/port over block production test #5603

wants to merge 63 commits into from

Conversation

ghost-not-in-the-shell
Copy link
Contributor

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

@ghost-not-in-the-shell ghost-not-in-the-shell requested review from a team as code owners August 7, 2020 18:54
@ghost-not-in-the-shell ghost-not-in-the-shell added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 10, 2020
@ghost-not-in-the-shell ghost-not-in-the-shell force-pushed the buildkite/port-over-block-production-test branch from 4840258 to bb14f99 Compare August 10, 2020 22:58
@ghost-not-in-the-shell ghost-not-in-the-shell removed the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 10, 2020
@ghost-not-in-the-shell ghost-not-in-the-shell added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 17, 2020
@O1ahmad O1ahmad force-pushed the buildkite/port-over-block-production-test branch from 4acbcfd to 52e359b Compare August 31, 2020 21:29
O1ahmad and others added 17 commits August 31, 2020 19:07
@O1ahmad
fix syntax error
d6d279f
@O1ahmad
add network_config to deploy(ed) type t
119a603
@O1ahmad
fix missing t scope
a2d85b9
@O1ahmad
set network config automation location and testnet name variables as …
2595035 
…a part of type t
@O1ahmad
fix testnet_dir reference for coda_automation.ml type t
52a6e52
@O1ahmad
set secret --from-file to current DIR to capture all eligible secret …
be7081b 
…files
@O1ahmad
explicitly set current ./ for test secret location
b84d4e4
@O1ahmad
sleep infinity in place of kubectl create secret to investigate
4161180
@O1ahmad
make use of secret var to avoid unused error
59b001c
@O1ahmad
retry fix
af54a62
@O1ahmad
fix syntax errors in debug coda_automation cmd
db1762c
@O1ahmad
another attempt to force framework to sleep for investigation
205a058
@O1ahmad
remove framework k8s secret creation overrides
1c1f959
@ghost-not-in-the-shell
test if kubectl is working or not
067a80d
@ghost-not-in-the-shell
add toolchain image to toolchain image
0c29588
@ghost-not-in-the-shell
update toolchain container
5acf8c9
@ghost-not-in-the-shell
remove kubectl check
b14485f
QuiteStochastic
QuiteStochastic reviewed Jan 14, 2021
View reviewed changes
Copy link
Contributor

@QuiteStochastic QuiteStochastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with buildkite but I would have thought that we should write this paramaterized by the test. we can pass in what test we want as an argument, like block-production peers send-payment etc, and then we don't need different scripts for each test, since the way the integration test framework is built is that each test runs the same way and uses the same infra. at the very least i'm certain that run-test.sh can be easily paramaterized by the test and should work for every one of them. the file buildkite/src/Jobs/BlockProductionTest.dhall can probably be paramaterized as well with simply a name change of the file, and un-hardcoding the let name = "BlockProductionTest"

buildkite/scripts/run-test.sh

echo "--- Run test executive"

./_build/default/src/app/test_executive/test_executive.exe --coda-image "$coda_daemon_image" block-production
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be better to add the --coda-automation-location coda-automation-integration-tests flag here in order to get the right automation directory, instead of setting the default to be ./coda-automation-integration-tests in coda-automation.ml. what do you guys think?

@ghost-not-in-the-shell ghost-not-in-the-shell changed the base branch from develop to compatible January 22, 2021 20:41
@imeckler imeckler force-pushed the buildkite/port-over-block-production-test branch from cd0b8d0 to 6727f32 Compare January 26, 2021 03:59
@ghost-not-in-the-shell ghost-not-in-the-shell deleted the buildkite/port-over-block-production-test branch March 17, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiteStochastic QuiteStochastic QuiteStochastic left review comments

@O1ahmad O1ahmad O1ahmad approved these changes

@bkase bkase Awaiting requested review from bkase

@emberian emberian Awaiting requested review from emberian

@imeckler imeckler Awaiting requested review from imeckler

@psteckler psteckler Awaiting requested review from psteckler

@mrmr1993 mrmr1993 Awaiting requested review from mrmr1993

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch consider-for-closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghost-not-in-the-shell @QuiteStochastic @O1ahmad @es92