-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pickles to delay prev proof processing #11014
Merged
mrmr1993
merged 11 commits into
develop
from
feature/refactor-pickles-to-delay-prev-proof-processing
Jun 1, 2022
Merged
Refactor pickles to delay prev proof processing #11014
mrmr1993
merged 11 commits into
develop
from
feature/refactor-pickles-to-delay-prev-proof-processing
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
added
the
ci-build-me
Add this label to trigger a circle+buildkite build for this branch
label
May 19, 2022
mrmr1993
changed the title
Feature/refactor pickles to delay prev proof processing
Refactor pickles to delay prev proof processing
May 19, 2022
This was referenced May 19, 2022
…-pickles-to-delay-prev-proof-processing
imeckler
approved these changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, sorry for the delay
mrmr1993
deleted the
feature/refactor-pickles-to-delay-prev-proof-processing
branch
June 1, 2022 13:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring of pickles, in particular to delay the processing of 'previous proofs' until the pickles circuit code has already started running.
This PR does not make the actual changes to allow passing the public inputs of the ancestor proofs from the
main
circuit; instead, this simply introduces mutable references and lazy computations to make it possible to do so. The changes to consume those public inputs and proofs from the circuit will be done in a follow-up PR.This PR is part of a series, building upon #11008.
Note for reviewers: It will be easiest to review this PR commit-by-commit, and with whitespace changes turned off (there are some nesting changes that caused a lot of changes to indentation).
Checklist: