Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pickles to delay prev proof processing #11014

Merged

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented May 19, 2022

This PR does some refactoring of pickles, in particular to delay the processing of 'previous proofs' until the pickles circuit code has already started running.

This PR does not make the actual changes to allow passing the public inputs of the ancestor proofs from the main circuit; instead, this simply introduces mutable references and lazy computations to make it possible to do so. The changes to consume those public inputs and proofs from the circuit will be done in a follow-up PR.

This PR is part of a series, building upon #11008.

Note for reviewers: It will be easiest to review this PR commit-by-commit, and with whitespace changes turned off (there are some nesting changes that caused a lot of changes to indentation).

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label May 19, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner May 19, 2022 16:35
@mrmr1993 mrmr1993 changed the title Feature/refactor pickles to delay prev proof processing Refactor pickles to delay prev proof processing May 19, 2022
Base automatically changed from feature/pickles-return-statement to develop May 24, 2022 18:53
Copy link
Member

@imeckler imeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, sorry for the delay

@mrmr1993 mrmr1993 merged commit 84e6724 into develop Jun 1, 2022
@mrmr1993 mrmr1993 deleted the feature/refactor-pickles-to-delay-prev-proof-processing branch June 1, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants