Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect default flag value #11208

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix incorrect default flag value #11208

merged 1 commit into from
Jun 7, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jun 7, 2022

I made a typo.. No wonder it didn't work on CI 😅

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 7, 2022
@mrmr1993
Fix incorrect default flag value
73771b0 
(No wonder this didn't work on CI...)
@mrmr1993 mrmr1993 force-pushed the fix/use-default-linker branch from c053231 to 73771b0 Compare June 7, 2022 17:15
@mrmr1993 mrmr1993 merged commit 7ac6b53 into develop Jun 7, 2022
@mrmr1993 mrmr1993 deleted the fix/use-default-linker branch June 7, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler