Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for development shell #12692

Merged
merged 24 commits into from
Mar 1, 2023
Merged

Fix for development shell #12692

merged 24 commits into from
Mar 1, 2023

Conversation

Smorci
Copy link
Contributor

@Smorci Smorci commented Feb 22, 2023

The pure development shell broke when the rust toolchain was updated.

@Smorci Smorci requested a review from a team as a code owner February 22, 2023 11:57
@Smorci
Copy link
Contributor Author

Smorci commented Feb 22, 2023

A workaround was implemented, the nix develop mina works after the nix/pin.sh script is executed. This something that has to be fixed from nixpkgs.

I will raise an issue in the near future and link it here with technical details.

@Smorci
Copy link
Contributor Author

Smorci commented Feb 23, 2023

The problem arose from these changes where the SYSROOT is determined based on the librustc_driver-*.so file.

There was a "FIX " for this in the nixpkgs-mozilla repository, however this isn't enough for our case.

We would have to copy the librustc_driver.so around because we are sharing components between mutliple sysroots. Here is a more detailed explanation on the matter.

This workaround works, as mentioned in the previously linked content, because we do not pass --sysroot twice.

Copy link
Member

@simisimis simisimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for explanation. This was not evident without it

@shimkiv shimkiv mentioned this pull request Feb 23, 2023
@Smorci
Copy link
Contributor Author

Smorci commented Feb 23, 2023

Merging is blocked because of permission issues. Nix CI is needed to merge

@Smorci
Copy link
Contributor Author

Smorci commented Feb 23, 2023

Here is the nixpkgs issue

Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this PR may have some unrelated changes. Please revert.

@Smorci Smorci added nix ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Feb 27, 2023
@Smorci
Copy link
Contributor Author

Smorci commented Feb 27, 2023

!ci-build-me

@mrmr1993 mrmr1993 merged commit 15787d2 into develop Mar 1, 2023
@mrmr1993 mrmr1993 deleted the bug/fix-rust-nix branch March 1, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants